From d7ed48ac6fccb70cff23bf513beab8f197cece60 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Mon, 1 Nov 2021 16:09:36 +0100 Subject: [PATCH] Add missing "emit"s Change-Id: I88a7397c7689b1e72cdd0e52077f8097443963c0 Reviewed-by: Eike Ziller --- src/libs/utils/archive.cpp | 11 ++++++----- src/plugins/clangtools/clangtool.cpp | 4 ++-- src/plugins/coreplugin/welcomepagehelper.cpp | 3 ++- src/plugins/help/helpwidget.cpp | 2 +- .../project/mesonrunconfiguration.cpp | 2 +- src/plugins/nim/project/nimbuildsystem.cpp | 6 +++--- src/plugins/projectexplorer/buildsystem.cpp | 2 +- .../projectexplorer/desktoprunconfiguration.cpp | 4 ++-- .../projectexplorer/jsonwizard/jsonfieldpage.cpp | 2 +- src/plugins/projectexplorer/runcontrol.cpp | 6 +++--- src/plugins/projectexplorer/target.cpp | 4 ++-- src/plugins/qmakeprojectmanager/qmakestep.cpp | 2 +- .../qmldesigner/assetexporterplugin/assetexporter.cpp | 2 +- .../components/curveeditor/curveeditor.cpp | 2 +- .../components/curveeditor/detail/graphicsview.cpp | 2 +- .../components/timelineeditor/timelinemovetool.cpp | 6 +++--- .../components/timelineeditor/timelinesectionitem.cpp | 2 +- 17 files changed, 32 insertions(+), 30 deletions(-) diff --git a/src/libs/utils/archive.cpp b/src/libs/utils/archive.cpp index b5521103443..d05b49eb6f6 100644 --- a/src/libs/utils/archive.cpp +++ b/src/libs/utils/archive.cpp @@ -208,7 +208,8 @@ Archive *Archive::unarchive(const FilePath &src, const FilePath &dest) [archive]() { if (!archive->m_process) return; - archive->outputReceived(QString::fromUtf8(archive->m_process->readAllStandardOutput())); + emit archive->outputReceived(QString::fromUtf8( + archive->m_process->readAllStandardOutput())); }, Qt::QueuedConnection); QObject::connect( @@ -218,7 +219,7 @@ Archive *Archive::unarchive(const FilePath &src, const FilePath &dest) [archive] { if (!archive->m_process) return; - archive->finished(archive->m_process->result() == QtcProcess::FinishedWithSuccess); + emit archive->finished(archive->m_process->result() == QtcProcess::FinishedWithSuccess); archive->m_process->deleteLater(); archive->m_process = nullptr; archive->deleteLater(); @@ -231,8 +232,8 @@ Archive *Archive::unarchive(const FilePath &src, const FilePath &dest) [archive](QProcess::ProcessError) { if (!archive->m_process) return; - archive->outputReceived(tr("Command failed.")); - archive->finished(false); + emit archive->outputReceived(tr("Command failed.")); + emit archive->finished(false); archive->m_process->deleteLater(); archive->m_process = nullptr; archive->deleteLater(); @@ -240,7 +241,7 @@ Archive *Archive::unarchive(const FilePath &src, const FilePath &dest) Qt::QueuedConnection); QTimer::singleShot(0, archive, [archive, tool, workingDirectory] { - archive->outputReceived( + emit archive->outputReceived( tr("Running %1\nin \"%2\".\n\n", "Running in ") .arg(tool->command.toUserOutput(), workingDirectory.toUserOutput())); }); diff --git a/src/plugins/clangtools/clangtool.cpp b/src/plugins/clangtools/clangtool.cpp index c8de027bce6..c422114f28e 100644 --- a/src/plugins/clangtools/clangtool.cpp +++ b/src/plugins/clangtools/clangtool.cpp @@ -671,8 +671,8 @@ void ClangTool::startTool(ClangTool::FileSelection fileSelection, m_runControl->setTarget(project->activeTarget()); m_stopAction->disconnect(); connect(m_stopAction, &QAction::triggered, m_runControl, [this] { - m_runControl->appendMessage(tr("Clang-Tidy and Clazy tool stopped by user."), - NormalMessageFormat); + emit m_runControl->appendMessage(tr("Clang-Tidy and Clazy tool stopped by user."), + NormalMessageFormat); m_runControl->initiateStop(); setState(State::StoppedByUser); }); diff --git a/src/plugins/coreplugin/welcomepagehelper.cpp b/src/plugins/coreplugin/welcomepagehelper.cpp index 00489b3de35..fbb4214b565 100644 --- a/src/plugins/coreplugin/welcomepagehelper.cpp +++ b/src/plugins/coreplugin/welcomepagehelper.cpp @@ -134,7 +134,8 @@ void GridProxyModel::setSourceModel(QAbstractItemModel *newModel) [this] (const QModelIndex &topLeft, const QModelIndex &bottomRight, const QVector &roles) { - QAbstractItemModel::dataChanged(mapFromSource(topLeft), mapFromSource(bottomRight), roles); + emit QAbstractItemModel::dataChanged(mapFromSource(topLeft), + mapFromSource(bottomRight), roles); }); } } diff --git a/src/plugins/help/helpwidget.cpp b/src/plugins/help/helpwidget.cpp index 1f235dcce62..528f4de7592 100644 --- a/src/plugins/help/helpwidget.cpp +++ b/src/plugins/help/helpwidget.cpp @@ -744,7 +744,7 @@ HelpViewer *HelpWidget::insertViewer(int index, const QUrl &url) connect(viewer, &HelpViewer::titleChanged, &m_model, [this, viewer] { const int i = indexOf(viewer); QTC_ASSERT(i >= 0, return ); - m_model.dataChanged(m_model.index(i, 0), m_model.index(i, 0)); + emit m_model.dataChanged(m_model.index(i, 0), m_model.index(i, 0)); }); connect(viewer, &HelpViewer::loadFinished, this, &HelpWidget::highlightSearchTerms); diff --git a/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp b/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp index 66b10555a58..a4590b41a1f 100644 --- a/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp +++ b/src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp @@ -92,7 +92,7 @@ void MesonRunConfiguration::updateTargetInformation() aspect()->setExecutable(bti.targetFilePath); aspect()->setDefaultWorkingDirectory( bti.workingDirectory); - aspect()->environmentChanged(); + emit aspect()->environmentChanged(); } MesonRunConfigurationFactory::MesonRunConfigurationFactory() diff --git a/src/plugins/nim/project/nimbuildsystem.cpp b/src/plugins/nim/project/nimbuildsystem.cpp index 95cfade2486..69c71e22278 100644 --- a/src/plugins/nim/project/nimbuildsystem.cpp +++ b/src/plugins/nim/project/nimbuildsystem.cpp @@ -140,7 +140,7 @@ bool NimProjectScanner::addFiles(const QStringList &filePaths) return !filePaths.contains(f); })); - requestReparse(); + emit requestReparse(); return true; } @@ -149,7 +149,7 @@ RemovedFilesFromProject NimProjectScanner::removeFiles(const QStringList &filePa { setExcludedFiles(Utils::filteredUnique(excludedFiles() + filePaths)); - requestReparse(); + emit requestReparse(); return RemovedFilesFromProject::Ok; } @@ -160,7 +160,7 @@ bool NimProjectScanner::renameFile(const QString &, const QString &to) files.removeOne(to); setExcludedFiles(files); - requestReparse(); + emit requestReparse(); return true; } diff --git a/src/plugins/projectexplorer/buildsystem.cpp b/src/plugins/projectexplorer/buildsystem.cpp index bf351c93575..8382d2d0600 100644 --- a/src/plugins/projectexplorer/buildsystem.cpp +++ b/src/plugins/projectexplorer/buildsystem.cpp @@ -337,7 +337,7 @@ void BuildSystem::setRootProjectNode(std::unique_ptr &&root) void BuildSystem::emitBuildSystemUpdated() { - target()->buildSystemUpdated(this); + emit target()->buildSystemUpdated(this); } void BuildSystem::setExtraData(const QString &buildKey, Utils::Id dataKey, const QVariant &data) diff --git a/src/plugins/projectexplorer/desktoprunconfiguration.cpp b/src/plugins/projectexplorer/desktoprunconfiguration.cpp index 32752b6498b..d0ab573b06f 100644 --- a/src/plugins/projectexplorer/desktoprunconfiguration.cpp +++ b/src/plugins/projectexplorer/desktoprunconfiguration.cpp @@ -120,7 +120,7 @@ void DesktopRunConfiguration::updateTargetInformation() else setDefaultDisplayName(profile.completeBaseName()); - aspect()->environmentChanged(); + emit aspect()->environmentChanged(); auto wda = aspect(); wda->setDefaultWorkingDirectory(bti.workingDirectory); @@ -144,7 +144,7 @@ void DesktopRunConfiguration::updateTargetInformation() aspect()->setExecutable(bti.targetFilePath); aspect()->setDefaultWorkingDirectory(bti.workingDirectory); - aspect()->environmentChanged(); + emit aspect()->environmentChanged(); } } diff --git a/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp b/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp index d6080f4e90f..3611a397ea9 100644 --- a/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp +++ b/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp @@ -962,7 +962,7 @@ void CheckBoxField::setChecked(bool value) QTC_ASSERT(w, return); w->setChecked(value); - w->clicked(value); + emit w->clicked(value); } bool CheckBoxField::validate(MacroExpander *expander, QString *message) diff --git a/src/plugins/projectexplorer/runcontrol.cpp b/src/plugins/projectexplorer/runcontrol.cpp index e63099b172c..7da09f1a340 100644 --- a/src/plugins/projectexplorer/runcontrol.cpp +++ b/src/plugins/projectexplorer/runcontrol.cpp @@ -851,7 +851,7 @@ void RunControlPrivate::onWorkerStopped(RunWorker *worker) void RunControlPrivate::showError(const QString &msg) { if (!msg.isEmpty()) - q->appendMessage(msg + '\n', ErrorMessageFormat); + emit q->appendMessage(msg + '\n', ErrorMessageFormat); } void RunControl::setupFormatter(OutputFormatter *formatter) const @@ -1480,9 +1480,9 @@ void RunWorker::reportFailure(const QString &msg) void RunWorker::appendMessage(const QString &msg, OutputFormat format, bool appendNewLine) { if (!appendNewLine || msg.endsWith('\n')) - d->runControl->appendMessage(msg, format); + emit d->runControl->appendMessage(msg, format); else - d->runControl->appendMessage(msg + '\n', format); + emit d->runControl->appendMessage(msg + '\n', format); } IDevice::ConstPtr RunWorker::device() const diff --git a/src/plugins/projectexplorer/target.cpp b/src/plugins/projectexplorer/target.cpp index 0d317debbd8..7d9d9c180b5 100644 --- a/src/plugins/projectexplorer/target.cpp +++ b/src/plugins/projectexplorer/target.cpp @@ -139,7 +139,7 @@ Target::Target(Project *project, Kit *k, _constructor_tag) : connect(DeviceManager::instance(), &DeviceManager::updated, this, &Target::updateDeviceState); connect(this, &Target::parsingStarted, this, [this, project] { - project->anyParsingStarted(this); + emit project->anyParsingStarted(this); }); connect(this, &Target::parsingFinished, this, [this, project](bool success) { @@ -147,7 +147,7 @@ Target::Target(Project *project, Kit *k, _constructor_tag) : updateDefaultRunConfigurations(); // For testing. emit SessionManager::instance()->projectFinishedParsing(project); - project->anyParsingFinished(this, success); + emit project->anyParsingFinished(this, success); }, Qt::QueuedConnection); // Must wait for run configs to change their enabled state. KitManager *km = KitManager::instance(); diff --git a/src/plugins/qmakeprojectmanager/qmakestep.cpp b/src/plugins/qmakeprojectmanager/qmakestep.cpp index 9e7c7f22307..3379aaebeba 100644 --- a/src/plugins/qmakeprojectmanager/qmakestep.cpp +++ b/src/plugins/qmakeprojectmanager/qmakestep.cpp @@ -532,7 +532,7 @@ QWidget *QMakeStep::createConfigWidget() qmakeBuildConfigChanged(); - updateSummary(); + emit updateSummary(); updateAbiWidgets(); updateEffectiveQMakeCall(); diff --git a/src/plugins/qmldesigner/assetexporterplugin/assetexporter.cpp b/src/plugins/qmldesigner/assetexporterplugin/assetexporter.cpp index 2f23cf2dd8b..5ac9a4ae8a8 100644 --- a/src/plugins/qmldesigner/assetexporterplugin/assetexporter.cpp +++ b/src/plugins/qmldesigner/assetexporterplugin/assetexporter.cpp @@ -460,7 +460,7 @@ void AssetExporter::State::change(const ParsingState &state) qCDebug(loggerInfo()) << "Assetimporter State change: Old: " << m_state << "New: " << state; if (m_state != state) { m_state = state; - m_assetExporter.stateChanged(m_state); + emit m_assetExporter.stateChanged(m_state); } } diff --git a/src/plugins/qmldesigner/components/curveeditor/curveeditor.cpp b/src/plugins/qmldesigner/components/curveeditor/curveeditor.cpp index 534799efcd9..c004055197d 100644 --- a/src/plugins/qmldesigner/components/curveeditor/curveeditor.cpp +++ b/src/plugins/qmldesigner/components/curveeditor/curveeditor.cpp @@ -178,7 +178,7 @@ QToolBar *CurveEditor::createToolBar(CurveEditorModel *model) cfspin->setMaximum(std::numeric_limits::max()); auto intSignal = static_cast(&QSpinBox::valueChanged); - connect(cfspin, intSignal, [model](int val) { model->commitCurrentFrame(val); }); + connect(cfspin, intSignal, [model](int val) { emit model->commitCurrentFrame(val); }); connect(m_view, &GraphicsView::currentFrameChanged, [cfspin](int val, bool notify) { if (notify) { cfspin->setValue(val); diff --git a/src/plugins/qmldesigner/components/curveeditor/detail/graphicsview.cpp b/src/plugins/qmldesigner/components/curveeditor/detail/graphicsview.cpp index 02a8dcd3a76..89084bc98bf 100644 --- a/src/plugins/qmldesigner/components/curveeditor/detail/graphicsview.cpp +++ b/src/plugins/qmldesigner/components/curveeditor/detail/graphicsview.cpp @@ -288,7 +288,7 @@ void GraphicsView::setCurrentFrame(int frame, bool notify) m_playhead.moveToFrame(clampedFrame, this); viewport()->update(); - currentFrameChanged(clampedFrame, notify); + emit currentFrameChanged(clampedFrame, notify); } void GraphicsView::scrollContent(double x, double y) diff --git a/src/plugins/qmldesigner/components/timelineeditor/timelinemovetool.cpp b/src/plugins/qmldesigner/components/timelineeditor/timelinemovetool.cpp index 82c84abeb60..edc158deb08 100644 --- a/src/plugins/qmldesigner/components/timelineeditor/timelinemovetool.cpp +++ b/src/plugins/qmldesigner/components/timelineeditor/timelinemovetool.cpp @@ -136,8 +136,8 @@ void TimelineMoveTool::mouseMoveEvent(TimelineMovableAbstractItem *item, targetFrame = snappedTargetFrame; } - scene()->statusBarMessageChanged(tr(TimelineConstants::statusBarKeyframe) - .arg(targetFrame)); + emit scene()->statusBarMessageChanged(tr(TimelineConstants::statusBarKeyframe) + .arg(targetFrame)); const QList selectedKeyframes = scene()->selectedKeyframes(); for (auto *keyframe : selectedKeyframes) { @@ -170,7 +170,7 @@ void TimelineMoveTool::mouseReleaseEvent(TimelineMovableAbstractItem *item, if (limitFrame > -999999.) { scene()->setCurrentFrame(limitFrame); - scene()->statusBarMessageChanged( + emit scene()->statusBarMessageChanged( tr(TimelineConstants::statusBarPlayheadFrame).arg(limitFrame)); return; } diff --git a/src/plugins/qmldesigner/components/timelineeditor/timelinesectionitem.cpp b/src/plugins/qmldesigner/components/timelineeditor/timelinesectionitem.cpp index 9174b4d49a5..31316f9aea9 100644 --- a/src/plugins/qmldesigner/components/timelineeditor/timelinesectionitem.cpp +++ b/src/plugins/qmldesigner/components/timelineeditor/timelinesectionitem.cpp @@ -959,7 +959,7 @@ void TimelineBarItem::itemMoved(const QPointF &start, const QPointF &end) else dragHandle(rect(), end, min, max); - abstractScrollGraphicsScene()->statusBarMessageChanged( + emit abstractScrollGraphicsScene()->statusBarMessageChanged( tr("Range from %1 to %2") .arg(qRound(mapFromSceneToFrame(rect().x()))) .arg(qRound(mapFromSceneToFrame(rect().width() + rect().x()))));