feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Use correct coding style and remove dead code

Browse Source 
Change-Id: I10967ee080076d40cf54aaf4ae28c63d78b7f216
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
This commit is contained in:
Ulf Hermann
2015-11-18 11:08:27 +01:00
parent d58b714a3a
commit d7f6dec98e
4 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/qmldebug/qmlprofilertraceclient.cpp
View File

@@ -221,7 +221,7 @@ void QmlProfilerTraceClient::messageReceived(const QByteArray &data)
stream >> id; stream >> id;
engineIds << id; engineIds << id;
} }
emit this->traceStarted(time, engineIds); emit traceStarted(time, engineIds);
d->maximumTime = time; d->maximumTime = time;
break; break;
} }
@@ -232,7 +232,7 @@ void QmlProfilerTraceClient::messageReceived(const QByteArray &data)
stream >> id; stream >> id;
engineIds << id; engineIds << id;
} }
emit this->traceFinished(time, engineIds); emit traceFinished(time, engineIds);
d->maximumTime = time; d->maximumTime = time;
d->maximumTime = qMax(time, d->maximumTime); d->maximumTime = qMax(time, d->maximumTime);
break; break;

1
src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp
View File

@@ -219,7 +219,6 @@ void QmlProfilerClientManager::disconnectClientSignals()
d->modelManager->traceTime(), &QmlProfilerTraceTime::decreaseStartTime); d->modelManager->traceTime(), &QmlProfilerTraceTime::decreaseStartTime);
disconnect(d->qmlclientplugin.data(), &QmlProfilerTraceClient::enabledChanged, disconnect(d->qmlclientplugin.data(), &QmlProfilerTraceClient::enabledChanged,
d->qmlclientplugin.data(), &QmlProfilerTraceClient::sendRecordingStatus); d->qmlclientplugin.data(), &QmlProfilerTraceClient::sendRecordingStatus);
// fixme: this should be unified for both clients
disconnect(d->qmlclientplugin.data(), &QmlProfilerTraceClient::recordingChanged, disconnect(d->qmlclientplugin.data(), &QmlProfilerTraceClient::recordingChanged,
d->profilerState, &QmlProfilerStateManager::setServerRecording); d->profilerState, &QmlProfilerStateManager::setServerRecording);
disconnect(d->profilerState, &QmlProfilerStateManager::requestedFeaturesChanged, disconnect(d->profilerState, &QmlProfilerStateManager::requestedFeaturesChanged,

2
src/plugins/qmlprofiler/qmlprofilerruncontrol.cpp
View File

@@ -268,7 +268,7 @@ void QmlProfilerRunControl::profilerStateChanged()
} }
} }
RunControl::StopResult QmlProfiler::QmlProfilerRunControl::stop() RunControl::StopResult QmlProfilerRunControl::stop()
{ {
StopResult result = Analyzer::AnalyzerRunControl::stop(); StopResult result = Analyzer::AnalyzerRunControl::stop();
if (d->m_profilerState->currentState() != QmlProfilerStateManager::Idle) if (d->m_profilerState->currentState() != QmlProfilerStateManager::Idle)

1
src/plugins/qmlprofiler/qmlprofilerruncontrol.h
View File

@@ -54,7 +54,6 @@ public:
signals: signals:
void processRunning(quint16 port); void processRunning(quint16 port);
void timeUpdate();
public slots: public slots:
bool startEngine(); bool startEngine();