forked from qt-creator/qt-creator
Give TextEditorActionHandler an explicit parent and unify usage.
The action handler implicitly passed ownership to ICore, which is non- to the action handler. We now consistently create the action handler in the editor factory, give ownership to the editor factory, and don't hold a reference to it. Change-Id: I4372f8de966e3ceff87c06c5528c6b54522c1d57 Reviewed-by: David Schulz <david.schulz@digia.com>
This commit is contained in:
@@ -31,9 +31,7 @@
|
||||
#define PYTHONEDITOR_PLUGIN_H
|
||||
|
||||
#include <extensionsystem/iplugin.h>
|
||||
#include <texteditor/texteditoractionhandler.h>
|
||||
#include <QSet>
|
||||
#include <QScopedPointer>
|
||||
|
||||
namespace PythonEditor {
|
||||
namespace Internal {
|
||||
@@ -65,7 +63,6 @@ public:
|
||||
private:
|
||||
static PythonEditorPlugin *m_instance;
|
||||
EditorFactory *m_factory;
|
||||
TextEditor::TextEditorActionHandler *m_actionHandler;
|
||||
QSet<QString> m_keywords;
|
||||
QSet<QString> m_magics;
|
||||
QSet<QString> m_builtins;
|
||||
|
||||
Reference in New Issue
Block a user