diff --git a/src/plugins/diffeditor/diffeditorplugin.cpp b/src/plugins/diffeditor/diffeditorplugin.cpp index a8b2b1331b9..617c19f7b7a 100644 --- a/src/plugins/diffeditor/diffeditorplugin.cpp +++ b/src/plugins/diffeditor/diffeditorplugin.cpp @@ -580,13 +580,12 @@ bool DiffEditorPlugin::initialize(const QStringList &arguments, QString *errorMe return true; } -void DiffEditorPlugin::addFuture(const QFuture &future) +FutureSynchronizer *DiffEditorPlugin::futureSynchronizer() { - QTC_ASSERT(s_instance, return); - s_instance->d->m_futureSynchronizer.addFuture(future); + QTC_ASSERT(s_instance, return nullptr); + return &s_instance->d->m_futureSynchronizer; } - } // namespace Internal } // namespace DiffEditor diff --git a/src/plugins/diffeditor/diffeditorplugin.h b/src/plugins/diffeditor/diffeditorplugin.h index 0cf10548bad..e3ec8924f47 100644 --- a/src/plugins/diffeditor/diffeditorplugin.h +++ b/src/plugins/diffeditor/diffeditorplugin.h @@ -8,6 +8,8 @@ #include #include +namespace Utils { class FutureSynchronizer; } + QT_BEGIN_NAMESPACE template class QFuture; @@ -39,9 +41,7 @@ public: bool initialize(const QStringList &arguments, QString *errorMessage) final; - template - static void addFuture(const QFuture &future) { addFuture(QFuture(future)); } - static void addFuture(const QFuture &future); + static Utils::FutureSynchronizer *futureSynchronizer(); private: class DiffEditorPluginPrivate *d = nullptr; diff --git a/src/plugins/diffeditor/sidebysidediffeditorwidget.cpp b/src/plugins/diffeditor/sidebysidediffeditorwidget.cpp index 4fba7076c45..9870baccfd1 100644 --- a/src/plugins/diffeditor/sidebysidediffeditorwidget.cpp +++ b/src/plugins/diffeditor/sidebysidediffeditorwidget.cpp @@ -25,6 +25,7 @@ #include #include +#include #include #include @@ -784,7 +785,7 @@ SideBySideDiffEditorWidget::~SideBySideDiffEditorWidget() { if (m_watcher) { m_watcher->cancel(); - DiffEditorPlugin::addFuture(m_watcher->future()); + DiffEditorPlugin::futureSynchronizer()->addFuture(m_watcher->future()); } } @@ -816,7 +817,7 @@ void SideBySideDiffEditorWidget::clear(const QString &message) editor->clearAll(message); if (m_watcher) { m_watcher->cancel(); - DiffEditorPlugin::addFuture(m_watcher->future()); + DiffEditorPlugin::futureSynchronizer()->addFuture(m_watcher->future()); m_watcher.reset(); m_controller.setBusyShowing(false); } diff --git a/src/plugins/diffeditor/unifieddiffeditorwidget.cpp b/src/plugins/diffeditor/unifieddiffeditorwidget.cpp index 400e9877551..663e53166f0 100644 --- a/src/plugins/diffeditor/unifieddiffeditorwidget.cpp +++ b/src/plugins/diffeditor/unifieddiffeditorwidget.cpp @@ -21,6 +21,7 @@ #include #include +#include #include #include #include @@ -57,7 +58,7 @@ UnifiedDiffEditorWidget::~UnifiedDiffEditorWidget() { if (m_watcher) { m_watcher->cancel(); - DiffEditorPlugin::addFuture(m_watcher->future()); + DiffEditorPlugin::futureSynchronizer()->addFuture(m_watcher->future()); } } @@ -204,7 +205,7 @@ void UnifiedDiffEditorWidget::clear(const QString &message) setSelections({}); if (m_watcher) { m_watcher->cancel(); - DiffEditorPlugin::addFuture(m_watcher->future()); + DiffEditorPlugin::futureSynchronizer()->addFuture(m_watcher->future()); m_watcher.reset(); m_controller.setBusyShowing(false); }