feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

plug huge memory leak

Browse Source 
in my quest to de-virtualize the ProItems i also devirtualized their
d'tors without providing a replacement. whoops.

Reviewed-by: dt
Task-number: QTCREATORBUG-1003
This commit is contained in:
Oswald Buddenhagen
2010-04-01 11:02:09 +02:00
parent efcdadd2bb
commit d86f7dcd68
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/shared/proparser/proitems.cpp
View File

@@ -45,10 +45,13 @@ ProBlock::~ProBlock()
{ {
for (ProItem *itm, *nitm = m_proitems; (itm = nitm); ) { for (ProItem *itm, *nitm = m_proitems; (itm = nitm); ) {
nitm = itm->m_next; nitm = itm->m_next;
if (itm->kind() == BlockKind) switch (itm->kind()) {
static_cast<ProBlock *>(itm)->deref(); case BlockKind: static_cast<ProBlock *>(itm)->deref(); break;
else case FunctionKind: delete static_cast<ProFunction *>(itm); break;
delete itm; case ConditionKind: delete static_cast<ProCondition *>(itm); break;
case OperatorKind: delete static_cast<ProOperator *>(itm); break;
case VariableKind: delete static_cast<ProVariable *>(itm); break;
}
} }
} }