feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Revert "Designer: Fix look-up of resources for UI files"

Browse Source 
This reverts commit 736eef24ca,
which breaks binary compatibility.

Change-Id: I696ad3e6efc6f02f595356c9864d69629eeef8bf
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Christian Kandeler
2019-10-02 11:15:27 +02:00
parent 312ff692b0
commit d907df0349
5 changed files with 17 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/plugins/designer/resourcehandler.cpp
View File

@@ -99,37 +99,26 @@ void ResourceHandler::updateResourcesHelper(bool updateProjectResources)
// Find the (sub-)project the file belongs to. We don't want to find resources
// from other parts of the project tree, e.g. via a qmake subdirs project.
Node * const fileNode = project->rootProjectNode()->findNode([&fileName](const Node *n) {
ProjectNode *projectNode = project->rootProjectNode();
Node * const fileNode = projectNode->findNode([&fileName](const Node *n) {
return n->filePath().toString() == fileName;
});
ProjectNode *projectNodeForUiFile = nullptr;
if (fileNode) {
// We do not want qbs groups or qmake .pri files here, as they contain only a subset
// of the relevant files.
projectNodeForUiFile = fileNode->parentProjectNode();
while (projectNodeForUiFile && !projectNodeForUiFile->isProduct())
projectNodeForUiFile = projectNodeForUiFile->parentProjectNode();
projectNode = fileNode->parentProjectNode();
while (projectNode && !projectNode->isProduct())
projectNode = projectNode->parentProjectNode();
}
if (!projectNodeForUiFile)
projectNodeForUiFile = project->rootProjectNode();
const auto useQrcFile = [projectNodeForUiFile, project](const Node *qrcNode) {
if (projectNodeForUiFile == project->rootProjectNode())
return true;
ProjectNode *projectNodeForQrcFile = qrcNode->parentProjectNode();
while (projectNodeForQrcFile && !projectNodeForQrcFile->isProduct())
projectNodeForQrcFile = projectNodeForQrcFile->parentProjectNode();
return !projectNodeForQrcFile
|| projectNodeForQrcFile == projectNodeForUiFile
|| projectNodeForQrcFile->productType() != ProductType::App;
};
if (!projectNode)
projectNode = project->rootProjectNode();
QStringList projectQrcFiles;
project->rootProjectNode()->forEachNode([&](FileNode *node) {
if (node->fileType() == FileType::Resource && useQrcFile(node))
projectNode->forEachNode([&](FileNode *node) {
if (node->fileType() == FileType::Resource)
projectQrcFiles.append(node->filePath().toString());
}, [&](FolderNode *node) {
if (dynamic_cast<ResourceEditor::ResourceTopLevelNode *>(node) && useQrcFile(node))
if (dynamic_cast<ResourceEditor::ResourceTopLevelNode *>(node))
projectQrcFiles.append(node->filePath().toString());
});
// Check if the user has chosen to update the lacking resource inside designer
@@ -141,7 +130,7 @@ void ResourceHandler::updateResourcesHelper(bool updateProjectResources)
}
if (!qrcPathsToBeAdded.isEmpty()) {
m_handlingResources = true;
projectNodeForUiFile->addFiles(qrcPathsToBeAdded);
projectNode->addFiles(qrcPathsToBeAdded);
m_handlingResources = false;
projectQrcFiles += qrcPathsToBeAdded;
}