feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Add and use a RunConfiguration::registerAspect<>

Browse Source 
... to register RunConfigurationAspect creating functions.

Change-Id: I9e7a2cef0bc134ac6a7becbd0b5ecb40c26ef118
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
hjk
2017-07-14 09:36:09 +02:00
parent b7babda68d
commit d93da5f5f1
5 changed files with 18 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -183,13 +183,16 @@ void IRunConfigurationAspect::resetProjectToGlobalSettings()
for a target, but still be runnable via the output tab.
*/
static std::vector<RunConfiguration::AspectFactory> theAspectFactories;
RunConfiguration::RunConfiguration(Target *target, Core::Id id) :
ProjectConfiguration(target, id)
{
Q_ASSERT(target);
ctor();
addExtraAspects();
for (const AspectFactory &factory : theAspectFactories)
addExtraAspect(factory(this));
}
RunConfiguration::RunConfiguration(Target *target, RunConfiguration *source) :
@@ -209,10 +212,9 @@ RunConfiguration::~RunConfiguration()
qDeleteAll(m_aspects);
}
void RunConfiguration::addExtraAspects()
void RunConfiguration::addAspectFactory(const AspectFactory &aspectFactory)
{
foreach (IRunControlFactory *factory, ExtensionSystem::PluginManager::getObjects<IRunControlFactory>())
addExtraAspect(factory->createRunConfigurationAspect(this));
theAspectFactories.push_back(aspectFactory);
}
void RunConfiguration::addExtraAspect(IRunConfigurationAspect *aspect)
@@ -542,22 +544,6 @@ RunControl *IRunControlFactory::create(RunConfiguration *runConfiguration, Core:
return runControl;
}
/*!
Returns an IRunConfigurationAspect to carry options for RunControls this
factory can create.
If no extra options are required, it is allowed to return null like the
default implementation does. This function is intended to be called from the
RunConfiguration constructor, so passing a RunConfiguration pointer makes
no sense because that object is under construction at the time.
*/
IRunConfigurationAspect *IRunControlFactory::createRunConfigurationAspect(RunConfiguration *rc)
{
Q_UNUSED(rc);
return nullptr;
}
/*!
\class ProjectExplorer::RunControl
\brief The RunControl class instances represent one item that is run.