feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Do not call QProcess::startDetached() with an empty string if no external

Browse Source 
editor is defined.
This commit is contained in:
mae
2008-12-02 15:39:53 +01:00
parent 05c35356ab
commit d9686f5b78
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/coreplugin/editormanager/editormanager.cpp
View File

@@ -1152,7 +1152,7 @@ void EditorManager::updateActions()
m_d->m_duplicateAction->setEnabled(curEditor != 0 && curEditor->duplicateSupported()); m_d->m_duplicateAction->setEnabled(curEditor != 0 && curEditor->duplicateSupported());
m_d->m_openInExternalEditorAction->setEnabled(curEditor != 0); m_d->m_openInExternalEditorAction->setEnabled(curEditor != 0 && !m_d->m_externalEditor.isEmpty());
} }
QList<IEditor*> EditorManager::openedEditors() const QList<IEditor*> EditorManager::openedEditors() const
@@ -1488,6 +1488,9 @@ QString EditorManager::externalEditorHelpText() const
void EditorManager::openInExternalEditor() void EditorManager::openInExternalEditor()
{ {
if (m_d->m_externalEditor.isEmpty())
return;
IEditor *editor = currentEditor(); IEditor *editor = currentEditor();
if (!editor) if (!editor)
return; return;
@@ -1499,7 +1502,6 @@ void EditorManager::openInExternalEditor()
return; return;
} }
QRect rect = editor->widget()->rect(); QRect rect = editor->widget()->rect();
QFont font = editor->widget()->font(); QFont font = editor->widget()->font();
QFontMetrics fm(font); QFontMetrics fm(font);