feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Wizards: sprinkle some consts

Browse Source 
Change-Id: I54d8a37ce508570ce85faeca049ad2b855b99e47
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Tim Jenssen
2017-09-26 11:05:22 +02:00
parent 08d3ef13a7
commit d96c80c1a5
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/projectexplorer/jsonwizard/jsonwizardfactory.cpp
View File

@@ -155,8 +155,8 @@ static JsonWizardFactory::Page parsePage(const QVariant &value, QString *errorMe
return p;
}
QVariantMap data = value.toMap();
QString strVal = data.value(QLatin1String(TYPE_ID_KEY)).toString();
const QVariantMap data = value.toMap();
const QString strVal = data.value(QLatin1String(TYPE_ID_KEY)).toString();
if (strVal.isEmpty()) {
*errorMessage = QCoreApplication::translate("ProjectExplorer::JsonWizardFactory", "Page has no typeId set.");
return p;
@@ -173,9 +173,9 @@ static JsonWizardFactory::Page parsePage(const QVariant &value, QString *errorMe
return p;
}
QString title = JsonWizardFactory::localizedString(data.value(QLatin1String(DISPLAY_NAME_KEY)));
QString subTitle = JsonWizardFactory::localizedString(data.value(QLatin1String(PAGE_SUB_TITLE_KEY)));
QString shortTitle = JsonWizardFactory::localizedString(data.value(QLatin1String(PAGE_SHORT_TITLE_KEY)));
const QString title = JsonWizardFactory::localizedString(data.value(QLatin1String(DISPLAY_NAME_KEY)));
const QString subTitle = JsonWizardFactory::localizedString(data.value(QLatin1String(PAGE_SUB_TITLE_KEY)));
const QString shortTitle = JsonWizardFactory::localizedString(data.value(QLatin1String(PAGE_SHORT_TITLE_KEY)));
bool ok;
int index = data.value(QLatin1String(PAGE_INDEX_KEY), -1).toInt(&ok);
@@ -236,8 +236,8 @@ QList<Core::IWizardFactory *> JsonWizardFactory::createWizardFactories()
QFile configFile(current.absoluteFilePath(wizardFileName));
configFile.open(QIODevice::ReadOnly);
QJsonParseError error;
QByteArray fileData = configFile.readAll();
QJsonDocument json = QJsonDocument::fromJson(fileData, &error);
const QByteArray fileData = configFile.readAll();
const QJsonDocument json = QJsonDocument::fromJson(fileData, &error);
configFile.close();
if (error.error != QJsonParseError::NoError) {