feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PerFProfiler: Use aspects more directly

Browse Source 
Change-Id: I6d15d32d9cd02acd9a95bb96cbde72beff506931
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-07-14 11:49:37 +02:00
parent 5bcf289fce
commit d9768caf76
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/perfprofiler/perfconfigeventsmodel.cpp
View File

@@ -22,7 +22,7 @@ PerfConfigEventsModel::PerfConfigEventsModel(PerfSettings *settings, QObject *pa
int PerfConfigEventsModel::rowCount(const QModelIndex &parent) const int PerfConfigEventsModel::rowCount(const QModelIndex &parent) const
{ {
return parent.isValid() ? 0 : m_settings->events.value().length(); return parent.isValid() ? 0 : m_settings->events().length();
} }
int PerfConfigEventsModel::columnCount(const QModelIndex &parent) const int PerfConfigEventsModel::columnCount(const QModelIndex &parent) const
@@ -40,7 +40,7 @@ QVariant PerfConfigEventsModel::data(const QModelIndex &index, int role) const
return QVariant(); // ignore return QVariant(); // ignore
} }
QString event = m_settings->events.value().value(index.row()); QString event = m_settings->events().value(index.row());
const EventDescription description = parseEvent(event); const EventDescription description = parseEvent(event);
switch (index.column()) { switch (index.column()) {
case ColumnEventType: { case ColumnEventType: {

6
src/plugins/perfprofiler/perfsettings.cpp
View File

@@ -99,10 +99,10 @@ void PerfSettings::addPerfRecordArguments(CommandLine *cmd) const
{ {
QString callgraphArg = callgraphMode.itemValue().toString(); QString callgraphArg = callgraphMode.itemValue().toString();
if (callgraphArg == Constants::PerfCallgraphDwarf) if (callgraphArg == Constants::PerfCallgraphDwarf)
callgraphArg += "," + QString::number(stackSize.value()); callgraphArg += "," + QString::number(stackSize());
QString events; QString events;
for (const QString &event : this->events.value()) { for (const QString &event : this->events()) {
if (!event.isEmpty()) { if (!event.isEmpty()) {
if (!events.isEmpty()) if (!events.isEmpty())
events.append(','); events.append(',');
@@ -113,7 +113,7 @@ void PerfSettings::addPerfRecordArguments(CommandLine *cmd) const
cmd->addArgs({"-e", events, cmd->addArgs({"-e", events,
"--call-graph", callgraphArg, "--call-graph", callgraphArg,
sampleMode.itemValue().toString(), sampleMode.itemValue().toString(),
QString::number(period.value())}); QString::number(period())});
cmd->addArgs(extraArguments(), CommandLine::Raw); cmd->addArgs(extraArguments(), CommandLine::Raw);
} }