Valgrind: Create a SuppressionsAspect

This is a fairly complex use case, as the corresponding widget looks the
same in global settings and Project settings, but behaves differently
(Project only stores a diff, is auto-apply). It also use two(!)
settings keys in the project case.

So while it works, it takes manual help for the cancel/apply and
toMap/fromMap. Looks like there is still some basic infrastructure
missing.

Change-Id: I25ab7b41616ee09ff9133e93b84f34947fc32988
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/valgrind/suppressiondialog.cpp

@@ -44,13 +44,12 @@
 #include <utils/fileutils.h>
 #include <utils/qtcassert.h>
 
-#include <QFile>
-
 #include <QDialogButtonBox>
+#include <QFile>
 #include <QFormLayout>
-#include <QPushButton>
 #include <QLabel>
 #include <QPlainTextEdit>
+#include <QPushButton>
 
 using namespace Valgrind::XmlProtocol;
 
@@ -217,7 +216,7 @@ void SuppressionDialog::accept()
         }
     }
 
-    m_settings->addSuppressionFiles(QStringList(path));
+    m_settings->suppressions.addSuppressionFile(path);
 
     QModelIndexList indices = m_view->selectionModel()->selectedRows();
     Utils::sort(indices, [](const QModelIndex &l, const QModelIndex &r) {