feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Add another fall-through annotation

Browse Source 
Change-Id: I2a44f7a12ea9f7f5bef2dd898b5f3575d8ecd190
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Christian Kandeler
2017-07-28 12:13:24 +02:00
committed by Tobias Hunger
parent 11ba8f0538
commit da06a6546d
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/projectexplorer/msvctoolchain.cpp
View File

@@ -29,6 +29,7 @@
#include "projectexplorerconstants.h" #include "projectexplorerconstants.h"
#include <utils/algorithm.h> #include <utils/algorithm.h>
#include <utils/qtcfallthrough.h>
#include <utils/synchronousprocess.h> #include <utils/synchronousprocess.h>
#include <utils/winutils.h> #include <utils/winutils.h>
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
@@ -102,7 +103,7 @@ static bool hostSupportsPlatform(MsvcToolChain::Platform platform)
if (platform == MsvcToolChain::amd64 || platform == MsvcToolChain::amd64_arm if (platform == MsvcToolChain::amd64 || platform == MsvcToolChain::amd64_arm
|| platform == MsvcToolChain::amd64_x86) || platform == MsvcToolChain::amd64_x86)
return true; return true;
// fall through (all x86 toolchains are also working on an amd64 host) Q_FALLTHROUGH(); // all x86 toolchains are also working on an amd64 host
case Utils::HostOsInfo::HostArchitectureX86: case Utils::HostOsInfo::HostArchitectureX86:
return platform == MsvcToolChain::x86 || platform == MsvcToolChain::x86_amd64 return platform == MsvcToolChain::x86 || platform == MsvcToolChain::x86_amd64
|| platform == MsvcToolChain::x86_ia64 || platform == MsvcToolChain::x86_arm; || platform == MsvcToolChain::x86_ia64 || platform == MsvcToolChain::x86_arm;