feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Ios: standardize IosRunConfiguration::initialize() signature

Browse Source 
Most other signatures look like RunConfiguration::initialize(Core::Id),
this here is part of unifying them completely.

Change-Id: I7cd2acc8ebe6ec8cef05272f18f0fa5ded94f930
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
This commit is contained in:
hjk
2017-11-10 17:46:10 +01:00
parent 43481d88da
commit da08c911c9
4 changed files with 23 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/ios/iosrunconfiguration.cpp
View File

@@ -105,10 +105,10 @@ IosRunConfiguration::IosRunConfiguration(Target *target)
this, &IosRunConfiguration::deviceChanges);
}
void IosRunConfiguration::initialize(Core::Id id, const FileName &path)
void IosRunConfiguration::initialize(Core::Id id)
{
RunConfiguration::initialize(id);
m_profilePath = path;
m_profilePath = pathFromId(id);
updateDisplayNames();
}
@@ -265,6 +265,15 @@ QString IosRunConfiguration::buildSystemTarget() const
return static_cast<QmakeProject *>(target()->project())->mapProFilePathToTarget(m_profilePath);
}
FileName IosRunConfiguration::pathFromId(Core::Id id)
{
QString pathStr = id.toString();
const QString prefix = Constants::IOS_RC_ID_PREFIX;
if (!pathStr.startsWith(prefix))
return Utils::FileName();
return Utils::FileName::fromString(pathStr.mid(prefix.size()));
}
QString IosRunConfiguration::disabledReason() const
{
Core::Id devType = DeviceTypeKitInformation::deviceTypeId(target()->kit());