QmlProfiler: Pimpl QmlProfilerPlugin class a bit more

... to be able to remove an unneeded use of the global object pool.

Plus some code cosmetics.

Change-Id: Ifdb0ff9cd40820a34a8951563402a50a594e4fdd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
hjk
2018-02-15 14:40:18 +01:00
parent 8059bf6204
commit da33f94e20
6 changed files with 26 additions and 32 deletions

View File

@@ -25,16 +25,12 @@
#pragma once
#include "qmlprofiler_global.h"
#include "qmlprofilersettings.h"
#include <extensionsystem/iplugin.h>
#include "qmlprofilertimelinemodel.h"
namespace QmlProfiler {
namespace Internal {
class QmlProfilerTool;
class QmlProfilerSettings;
class QmlProfilerPlugin : public ExtensionSystem::IPlugin
{
@@ -42,16 +38,15 @@ class QmlProfilerPlugin : public ExtensionSystem::IPlugin
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "QmlProfiler.json")
public:
bool initialize(const QStringList &arguments, QString *errorString) override;
void extensionsInitialized() override;
ShutdownFlag aboutToShutdown() override;
static QmlProfilerSettings *globalSettings();
QList<QObject *> createTestObjects() const override;
private:
QmlProfilerTool *m_profilerTool = nullptr;
bool initialize(const QStringList &arguments, QString *errorString) final;
void extensionsInitialized() final;
ShutdownFlag aboutToShutdown() final;
QList<QObject *> createTestObjects() const final;
class QmlProfilerPluginPrivate *d = nullptr;
};
} // namespace Internal