feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Pimpl QmlProfilerPlugin class a bit more

Browse Source 
... to be able to remove an unneeded use of the global object pool.

Plus some code cosmetics.

Change-Id: Ifdb0ff9cd40820a34a8951563402a50a594e4fdd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
hjk
2018-02-15 14:40:18 +01:00
parent 8059bf6204
commit da33f94e20
6 changed files with 26 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmlprofiler/tests/qmlprofilertool_test.cpp
View File

@@ -41,7 +41,7 @@ namespace Internal {
void QmlProfilerToolTest::testAttachToWaitingApplication()
{
QmlProfilerTool profilerTool(nullptr);
QmlProfilerTool profilerTool;
QTcpServer server;
QUrl serverUrl = Utils::urlFromLocalHostAndFreePort();
QVERIFY(serverUrl.port() >= 0);
@@ -79,7 +79,7 @@ void QmlProfilerToolTest::testAttachToWaitingApplication()
void QmlProfilerToolTest::testClearEvents()
{
QmlProfilerTool profilerTool(nullptr);
QmlProfilerTool profilerTool;
QmlProfilerModelManager *modelManager = profilerTool.modelManager();
QVERIFY(modelManager);
QmlProfilerStateManager *stateManager = profilerTool.stateManager();