From da5852a3b36b67c394f9f1a62c0a45579966f2e2 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Wed, 9 Sep 2020 17:58:47 +0200
Subject: [PATCH] ProjectExplorer: Remove ArgumentsAspect::argumentsChanged
 signal

The base Aspect::changed() is good enough.

Change-Id: Ib660e06cf4240198f7f73948ea0922a11568d4a2
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
---
 src/plugins/boot2qt/qdbrunconfiguration.cpp             | 2 +-
 src/plugins/nim/project/nimblebuildstep.cpp             | 2 +-
 src/plugins/projectexplorer/runconfigurationaspects.cpp | 2 +-
 src/plugins/projectexplorer/runconfigurationaspects.h   | 3 ---
 4 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/plugins/boot2qt/qdbrunconfiguration.cpp b/src/plugins/boot2qt/qdbrunconfiguration.cpp
index 331cd864ca9..9c75d038edb 100644
--- a/src/plugins/boot2qt/qdbrunconfiguration.cpp
+++ b/src/plugins/boot2qt/qdbrunconfiguration.cpp
@@ -63,7 +63,7 @@ public:
                      + ' ' + usedExecutable + ' ' + args);
         };
 
-        connect(argumentsAspect, &ArgumentsAspect::argumentsChanged, this, updateCommandLine);
+        connect(argumentsAspect, &ArgumentsAspect::changed, this, updateCommandLine);
         connect(exeAspect, &ExecutableAspect::changed, this, updateCommandLine);
         updateCommandLine();
     }
diff --git a/src/plugins/nim/project/nimblebuildstep.cpp b/src/plugins/nim/project/nimblebuildstep.cpp
index a0d1e5f85b3..fd0cf85a034 100644
--- a/src/plugins/nim/project/nimblebuildstep.cpp
+++ b/src/plugins/nim/project/nimblebuildstep.cpp
@@ -120,7 +120,7 @@ NimbleBuildStep::NimbleBuildStep(BuildStepList *parentList, Id id)
     QTC_ASSERT(buildConfiguration(), return);
     QObject::connect(buildConfiguration(), &BuildConfiguration::buildTypeChanged,
                      m_arguments, &ArgumentsAspect::resetArguments);
-    QObject::connect(m_arguments, &ArgumentsAspect::argumentsChanged,
+    QObject::connect(m_arguments, &ArgumentsAspect::changed,
                      this, &NimbleBuildStep::onArgumentsChanged);
 }
 
diff --git a/src/plugins/projectexplorer/runconfigurationaspects.cpp b/src/plugins/projectexplorer/runconfigurationaspects.cpp
index 1e79c47d0ea..ae2f1fb1e5b 100644
--- a/src/plugins/projectexplorer/runconfigurationaspects.cpp
+++ b/src/plugins/projectexplorer/runconfigurationaspects.cpp
@@ -281,7 +281,7 @@ void ArgumentsAspect::setArguments(const QString &arguments)
 {
     if (arguments != m_arguments) {
         m_arguments = arguments;
-        emit argumentsChanged(arguments);
+        emit changed();
     }
     if (m_chooser && m_chooser->text() != arguments)
         m_chooser->setText(arguments);
diff --git a/src/plugins/projectexplorer/runconfigurationaspects.h b/src/plugins/projectexplorer/runconfigurationaspects.h
index 89907f07951..59d2d141b35 100644
--- a/src/plugins/projectexplorer/runconfigurationaspects.h
+++ b/src/plugins/projectexplorer/runconfigurationaspects.h
@@ -113,9 +113,6 @@ public:
     void setResetter(const std::function<QString()> &resetter);
     void resetArguments();
 
-signals:
-    void argumentsChanged(const QString &arguments);
-
 private:
     void fromMap(const QVariantMap &map) override;
     void toMap(QVariantMap &map) const override;