feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LinuxDeviceProcess: Quote environment variable values.

Browse Source 
The current code breaks for values that contain spaces.

Change-Id: Ia2a318dcac09a8d1c1ce368378a33c633f28bf49
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Christian Kandeler
2014-05-06 15:23:24 +02:00
parent f1cfb5c515
commit da85540971
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/remotelinux/linuxdeviceprocess.cpp
View File

@@ -61,7 +61,13 @@ QString LinuxDeviceProcess::fullCommandLine() const
fullCommandLine.append(QLatin1String("cd ")).append(quote(m_workingDir))
.append(QLatin1String(" && "));
}
const QString envString = environment().toStringList().join(QLatin1String(" "));
QString envString;
for (auto it = environment().constBegin(); it != environment().constEnd(); ++it) {
if (!envString.isEmpty())
envString += QLatin1Char(' ');
envString.append(it.key()).append(QLatin1String("='")).append(it.value())
.append(QLatin1Char('\''));
}
if (!envString.isEmpty())
fullCommandLine.append(QLatin1Char(' ')).append(envString);
if (!fullCommandLine.isEmpty())