feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Editors: Provide a base implementation for duplicate{,Supported}

Browse Source 
Helps avoiding trivial re-implementations.

Change-Id: Iaa2e6b92503a2b9553432568c2047c28899c7ea6
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
hjk
2013-05-27 13:12:44 +02:00
committed by Eike Ziller
parent 8e50dc182c
commit daad8e238e
17 changed files with 6 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/diffeditor/diffeditoreditable.cpp
View File

@@ -98,17 +98,6 @@ void DiffEditorEditable::setDisplayName(const QString &title)
emit changed();
}
bool DiffEditorEditable::duplicateSupported() const
{
return false;
}
Core::IEditor *DiffEditorEditable::duplicate(QWidget *parent)
{
Q_UNUSED(parent)
return 0;
}
Core::Id DiffEditorEditable::id() const
{
return Constants::DIFF_EDITOR_ID;

2
src/plugins/diffeditor/diffeditoreditable.h
View File

@@ -65,8 +65,6 @@ public:
Core::IDocument *document();
QString displayName() const;
void setDisplayName(const QString &title);
bool duplicateSupported() const;
Core::IEditor *duplicate(QWidget *parent);
Core::Id id() const;
bool isTemporary() const { return true; }
DiffEditorWidget *editorWidget() const { return m_editorWidget; }

6
src/plugins/diffeditor/diffeditorwidget.cpp
View File

@@ -101,11 +101,9 @@ class DiffViewEditorEditable : public BaseTextEditor
Q_OBJECT
public:
DiffViewEditorEditable(BaseTextEditorWidget *editorWidget) : BaseTextEditor(editorWidget) {}
virtual Core::Id id() const { return "DiffViewEditor"; }
virtual bool duplicateSupported() const { return false; }
virtual IEditor *duplicate(QWidget *parent) { Q_UNUSED(parent) return 0; }
virtual bool isTemporary() const { return false; }
Core::Id id() const { return "DiffViewEditor"; }
bool isTemporary() const { return false; }
};