Utils: Separate the filter icon from the expand arrow

...so that the filter funnel can be used stand-alone

Change-Id: Ic8675954edd4234f84de8caffedd1a67b67b2edd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Alessandro Portale
2018-06-26 19:08:59 +02:00
parent afe0a73f91
commit dad5e41ca9
8 changed files with 29 additions and 9 deletions

Binary file not shown.

Before

Width:  |  Height:  |  Size: 127 B

After

Width:  |  Height:  |  Size: 164 B

Binary file not shown.

Before

Width:  |  Height:  |  Size: 170 B

After

Width:  |  Height:  |  Size: 193 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 110 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 128 B

View File

@@ -207,5 +207,7 @@
<file>images/lightbulb@2x.png</file>
<file>images/lightbulbcap.png</file>
<file>images/lightbulbcap@2x.png</file>
<file>images/toolbuttonexpandarrow.png</file>
<file>images/toolbuttonexpandarrow@2x.png</file>
</qresource>
</RCC>

View File

@@ -176,7 +176,8 @@ const Icon CLOSE_SPLIT_LEFT({
const Icon CLOSE_SPLIT_RIGHT({
{QLatin1String(":/utils/images/splitbutton_closeright.png"), Theme::IconsBaseColor}});
const Icon FILTER({
{QLatin1String(":/utils/images/filtericon.png"), Theme::IconsBaseColor}});
{QLatin1String(":/utils/images/filtericon.png"), Theme::IconsBaseColor},
{QLatin1String(":/utils/images/toolbuttonexpandarrow.png"), Theme::IconsBaseColor}});
const Icon LINK({
{QLatin1String(":/utils/images/linkicon.png"), Theme::PanelTextColorMid}}, Icon::Tint);
const Icon LINK_TOOLBAR({

View File

@@ -33,8 +33,9 @@
#include <cpptools/cppmodelmanager.h>
#include <projectexplorer/session.h>
#include <utils/algorithm.h>
#include <utils/icon.h>
#include <utils/qtcassert.h>
#include <utils/utilsicons.h>
#include <utils/theme/theme.h>
#include <QRegExp>
@@ -112,7 +113,9 @@ QVariant GTestTreeItem::data(int column, int role) const
case Qt::DecorationRole:
if (type() == GroupNode
&& GTestFramework::groupMode() == GTest::Constants::GTestFilter) {
return Utils::Icons::FILTER.icon(); // TODO replace by an 'inked' filter w/o arrow
static const QIcon filterIcon = Utils::Icon({{":/utils/images/filtericon.png",
Utils::Theme::PanelTextColorMid}}).icon();
return filterIcon;
}
break;
case Qt::ToolTipRole:

View File

@@ -3376,12 +3376,6 @@
width="16"
id="rect3817-2-9-1-9-6-2"
style="fill:#ffffff" />
<path
sodipodi:nodetypes="cccc"
inkscape:connector-curvature="0"
id="path4784"
d="m 210,595 -2.5,2.5 -2.5,-2.5 z"
style="fill:#000000;fill-opacity:1;stroke:none" />
<polygon
transform="translate(93.999999,334)"
id="polygon4959-9"
@@ -6012,6 +6006,26 @@
inkscape:connector-curvature="0"
sodipodi:nodetypes="cccccccccccccccccccc" />
</g>
<g
id="src/libs/utils/images/toolbuttonexpandarrow"
style="display:inline"
clip-path="url(#clipPath4845-7)"
transform="translate(-131,-32)">
<use
x="0"
y="0"
xlink:href="#backgroundRect"
id="use5933-0-9"
width="100%"
height="100%"
transform="translate(211,148)" />
<path
sodipodi:nodetypes="cccc"
inkscape:connector-curvature="0"
id="path4784-17"
d="m 210,595 -2.5,2.5 -2.5,-2.5 z"
style="fill:#000000;fill-opacity:1;stroke:none" />
</g>
</g>
<g
inkscape:groupmode="layer"

Before

Width:  |  Height:  |  Size: 356 KiB

After

Width:  |  Height:  |  Size: 356 KiB