From daedaf3d1cb7a401893b1f881da2167ecd3600ab Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 2 Feb 2024 11:20:43 +0100 Subject: [PATCH] Axivion: Don't store issue id inside AxivionTextMark Pass it directly to internal lambdas instead. Change-Id: I2f09004c0fe005e47610a054e308ded19619c438 Reviewed-by: Reviewed-by: Christian Stenger --- src/plugins/axivion/axivionplugin.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/plugins/axivion/axivionplugin.cpp b/src/plugins/axivion/axivionplugin.cpp index a718d3723be..260a9f50c4e 100644 --- a/src/plugins/axivion/axivionplugin.cpp +++ b/src/plugins/axivion/axivionplugin.cpp @@ -157,14 +157,10 @@ class AxivionTextMark : public TextEditor::TextMark { public: AxivionTextMark(const FilePath &filePath, const ShortIssue &issue); - -private: - QString m_id; }; AxivionTextMark::AxivionTextMark(const FilePath &filePath, const ShortIssue &issue) : TextEditor::TextMark(filePath, issue.lineNumber, {Tr::tr("Axivion"), AxivionTextMarkId}) - , m_id(issue.id) { const QString markText = issue.entity.isEmpty() ? issue.message : issue.entity + ": " + issue.message; @@ -172,11 +168,11 @@ AxivionTextMark::AxivionTextMark(const FilePath &filePath, const ShortIssue &iss setIcon(iconForIssue("SV")); // FIXME adapt to the issue setPriority(TextEditor::TextMark::NormalPriority); setLineAnnotation(markText); - setActionsProvider([this]{ + setActionsProvider([id = issue.id] { auto action = new QAction; action->setIcon(Utils::Icons::INFO.icon()); action->setToolTip(Tr::tr("Show rule details")); - QObject::connect(action, &QAction::triggered, dd, [this] { dd->fetchIssueInfo(m_id); }); + QObject::connect(action, &QAction::triggered, dd, [id] { dd->fetchIssueInfo(id); }); return QList{action}; }); }