From db01563fdaafe4dca099d85c8924a4baa85b3030 Mon Sep 17 00:00:00 2001 From: Tim Jenssen Date: Tue, 28 Jan 2020 10:56:34 +0100 Subject: [PATCH] ProjectExplorer: make sure there is no nullptr buildConfiguration This caused a crash in QtDesinStudio calling the preview in buildmanager.cpp: for (const BuildConfiguration * const bc : buildConfigsForSelection(target, configSelection)) { bsl = isBuild ? bc->buildSteps() : bc->cleanSteps(); //bc was nullptr here Change-Id: I67d165adb1b81c1b68fbc6fb38b67d4d2887eed1 Reviewed-by: hjk Reviewed-by: Tim Jenssen --- src/plugins/projectexplorer/buildmanager.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/projectexplorer/buildmanager.cpp b/src/plugins/projectexplorer/buildmanager.cpp index f6d5a224ea1..663cf22f8e4 100644 --- a/src/plugins/projectexplorer/buildmanager.cpp +++ b/src/plugins/projectexplorer/buildmanager.cpp @@ -81,7 +81,9 @@ static const QList buildConfigsForSelection(const Target * { if (configSelection == ConfigSelection::All) return target->buildConfigurations(); - return {target->activeBuildConfiguration()}; + else if (target->activeBuildConfiguration()) + return {target->activeBuildConfiguration()}; + return {}; } static int queue(const QList &projects, const QList &stepIds,