feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Remove a parameter with fixed value

Browse Source 
Internal::displayDebugger's updateEngine parameter was always true.

Change-Id: I27e91b7327ef7f4ccfb7718ad47fe5316660ea17
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-05-25 15:12:34 +02:00
parent a4d1af9828
commit db1174b6b8
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/debugger/debuggercore.h
View File

@@ -77,7 +77,7 @@ void showMessage(const QString &msg, int channel, int timeout = -1);
bool isReverseDebugging();
void runControlStarted(DebuggerRunTool *runTool);
void runControlFinished(DebuggerRunTool *runTool);
void displayDebugger(DebuggerRunTool *runTool, bool updateEngine);
void displayDebugger(DebuggerRunTool *runTool);
void synchronizeBreakpoints();
void saveModeToRestore();

11
src/plugins/debugger/debuggerplugin.cpp
View File

@@ -747,7 +747,7 @@ public:
void runControlFinished(DebuggerRunTool *runTool);
void remoteCommand(const QStringList &options);
void displayDebugger(DebuggerRunTool *runTool, bool updateEngine = true);
void displayDebugger(DebuggerRunTool *runTool);
void dumpLog();
void cleanupViews();
@@ -2379,7 +2379,7 @@ void DebuggerPluginPrivate::requestMark(TextEditorWidget *widget, int lineNumber
}
// If updateEngine is set, the engine will update its threads/modules and so forth.
void DebuggerPluginPrivate::displayDebugger(DebuggerRunTool *runTool, bool updateEngine)
void DebuggerPluginPrivate::displayDebugger(DebuggerRunTool *runTool)
{
QTC_ASSERT(runTool, return);
DebuggerEngine *engine = runTool ? runTool->engine() : dummyEngine();
@@ -2387,8 +2387,7 @@ void DebuggerPluginPrivate::displayDebugger(DebuggerRunTool *runTool, bool updat
disconnectEngine();
connectEngine(runTool);
if (updateEngine)
engine->updateAll();
engine->updateAll();
engine->updateViews();
}
@@ -3197,9 +3196,9 @@ void runControlFinished(DebuggerRunTool *runTool)
dd->runControlFinished(runTool);
}
void displayDebugger(DebuggerRunTool *runTool, bool updateEngine)
void displayDebugger(DebuggerRunTool *runTool)
{
dd->displayDebugger(runTool, updateEngine);
dd->displayDebugger(runTool);
}
void synchronizeBreakpoints()

2
src/plugins/debugger/snapshothandler.cpp
View File

@@ -207,7 +207,7 @@ void SnapshotHandler::activateSnapshot(int index)
beginResetModel();
m_currentIndex = index;
//qDebug() << "ACTIVATING INDEX: " << m_currentIndex << " OF " << size();
Internal::displayDebugger(at(index), true);
Internal::displayDebugger(at(index));
endResetModel();
}