feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Remove one use of Java-style iterator

Browse Source 
Also take advantage of the fact that filtering a list can be done
more straightforward than creating a full copy and removing
non-matching items.

Change-Id: I95e983873d4273b2302c4b3bbaeddb4390310d99
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-07-25 16:04:34 +02:00
parent 928550ed79
commit db6cd708db
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/qmldesigner/designercore/model/model.cpp
View File

@@ -1393,14 +1393,8 @@ void ModelPrivate::notifyNodeOrderChanged(const InternalNodeListPropertyPointer
void ModelPrivate::setSelectedNodes(const QList<InternalNode::Pointer> &selectedNodeList) void ModelPrivate::setSelectedNodes(const QList<InternalNode::Pointer> &selectedNodeList)
{ {
QList<InternalNode::Pointer> sortedSelectedList
QList<InternalNode::Pointer> sortedSelectedList(selectedNodeList); = Utils::filtered(selectedNodeList, &InternalNode::isValid);
QMutableListIterator<InternalNode::Pointer> iterator(sortedSelectedList);
while (iterator.hasNext()) {
InternalNode::Pointer node(iterator.next());
if (!node->isValid())
iterator.remove();
}
sortedSelectedList = sortedSelectedList.toSet().toList(); sortedSelectedList = sortedSelectedList.toSet().toList();
Utils::sort(sortedSelectedList); Utils::sort(sortedSelectedList);