From db897f8146f7ddd1637bb20e052d8d784af0b84a Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Thu, 6 Feb 2014 10:22:38 +0100 Subject: [PATCH] Fix build on Windows For some reason it doesn't like signals with QFutures. Going back to pointers, but copying the future from there when it's used. Change-Id: I8dea0817b4e59ede6874ab8be01f22a92e7402a0 Reviewed-by: Erik Verbruggen --- src/plugins/cppeditor/cppeditor.cpp | 8 ++++---- src/plugins/cppeditor/cppeditor.h | 2 +- src/plugins/cpptools/cpptoolseditorsupport.cpp | 4 ++-- src/plugins/cpptools/cpptoolseditorsupport.h | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/plugins/cppeditor/cppeditor.cpp b/src/plugins/cppeditor/cppeditor.cpp index 47a1b588545..b07fa98167f 100644 --- a/src/plugins/cppeditor/cppeditor.cpp +++ b/src/plugins/cppeditor/cppeditor.cpp @@ -549,8 +549,8 @@ void CPPEditorWidget::ctor() this, SLOT(onDocumentUpdated())); connect(editorSupport, SIGNAL(semanticInfoUpdated(CppTools::SemanticInfo)), this, SLOT(updateSemanticInfo(CppTools::SemanticInfo))); - connect(editorSupport, SIGNAL(highlighterStarted(QFuture,uint)), - this, SLOT(highlighterStarted(QFuture,uint))); + connect(editorSupport, SIGNAL(highlighterStarted(QFuture*,uint)), + this, SLOT(highlighterStarted(QFuture*,uint))); } m_highlightRevision = 0; @@ -1608,7 +1608,7 @@ void CPPEditorWidget::semanticRehighlight(bool force) m_modelManager->cppEditorSupport(editor())->recalculateSemanticInfoDetached(force); } -void CPPEditorWidget::highlighterStarted(QFuture highlighter, +void CPPEditorWidget::highlighterStarted(QFuture *highlighter, unsigned revision) { m_highlightRevision = revision; @@ -1619,7 +1619,7 @@ void CPPEditorWidget::highlighterStarted(QFuture connect(m_highlightWatcher.data(), SIGNAL(finished()), SLOT(finishHighlightSymbolUsages())); - m_highlightWatcher->setFuture(highlighter); + m_highlightWatcher->setFuture(QFuture(*highlighter)); } void CPPEditorWidget::updateSemanticInfo(const SemanticInfo &semanticInfo) diff --git a/src/plugins/cppeditor/cppeditor.h b/src/plugins/cppeditor/cppeditor.h index 4b9b01f8ffa..6220db33919 100644 --- a/src/plugins/cppeditor/cppeditor.h +++ b/src/plugins/cppeditor/cppeditor.h @@ -156,7 +156,7 @@ public slots: void showPreProcessorWidget(); void renameUsagesNow(const QString &replacement = QString()); void semanticRehighlight(bool force = false); - void highlighterStarted(QFuture highlighter, + void highlighterStarted(QFuture *highlighter, unsigned revision); protected: diff --git a/src/plugins/cpptools/cpptoolseditorsupport.cpp b/src/plugins/cpptools/cpptoolseditorsupport.cpp index 6a31f98f852..4564bfc9384 100644 --- a/src/plugins/cpptools/cpptoolseditorsupport.cpp +++ b/src/plugins/cpptools/cpptoolseditorsupport.cpp @@ -390,7 +390,7 @@ void CppEditorSupport::startHighlighting() m_highlighter = m_highlightingSupport->highlightingFuture(doc, snapshot); m_lastHighlightRevision = revision; - emit highlighterStarted(m_highlighter, m_lastHighlightRevision); + emit highlighterStarted(&m_highlighter, m_lastHighlightRevision); } else { const unsigned revision = currentSource(false).revision; if (m_lastHighlightRevision == revision) @@ -400,7 +400,7 @@ void CppEditorSupport::startHighlighting() static const Document::Ptr dummyDoc; static const Snapshot dummySnapshot; m_highlighter = m_highlightingSupport->highlightingFuture(dummyDoc, dummySnapshot); - emit highlighterStarted(m_highlighter, m_lastHighlightRevision); + emit highlighterStarted(&m_highlighter, m_lastHighlightRevision); } } diff --git a/src/plugins/cpptools/cpptoolseditorsupport.h b/src/plugins/cpptools/cpptoolseditorsupport.h index 1d6179e5d89..f9ba8762561 100644 --- a/src/plugins/cpptools/cpptoolseditorsupport.h +++ b/src/plugins/cpptools/cpptoolseditorsupport.h @@ -132,7 +132,7 @@ signals: void documentUpdated(); void diagnosticsChanged(); void semanticInfoUpdated(CppTools::SemanticInfo); - void highlighterStarted(QFuture, unsigned revision); + void highlighterStarted(QFuture *, unsigned revision); private slots: void onMimeTypeChanged();