feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

UnitTest: Use the os temp dir instead of a hard coded "/tmp"

Browse Source 
Change-Id: Ief32d3ca9aa0ccee25a1415f84552117c7323a31
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2016-11-28 17:03:47 +01:00
parent 600b85defa
commit dca3410ee8
1 changed files with 29 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
tests/unit/unittest/refactoringcompilationdatabase-test.cpp
View File

@@ -27,13 +27,15 @@
#include <refactoringcompilationdatabase.h> #include <refactoringcompilationdatabase.h>
#include <utils/smallstring.h>
#include <QDir>
using testing::Contains; using testing::Contains;
using testing::IsEmpty; using testing::IsEmpty;
using testing::Not; using testing::Not;
using testing::PrintToString; using testing::PrintToString;
using ClangBackEnd::RefactoringCompilationDatabase;
namespace { namespace {
MATCHER_P3(IsCompileCommand, directory, fileName, commandLine, MATCHER_P3(IsCompileCommand, directory, fileName, commandLine,
@@ -51,48 +53,53 @@ MATCHER_P3(IsCompileCommand, directory, fileName, commandLine,
return true; return true;
} }
TEST(RefactoringCompilationDatabase, GetAllFilesContainsTranslationUnit) class RefactoringCompilationDatabase : public ::testing::Test
{ {
RefactoringCompilationDatabase database; protected:
database.addFile("/tmp", "data.cpp", {"cc", "data.cpp", "-DNO_DEBUG"}); void SetUp();
protected:
ClangBackEnd::RefactoringCompilationDatabase database;
Utils::SmallString temporaryDirectoryPath = QDir::toNativeSeparators(QDir::tempPath());
Utils::SmallString temporarySourceFilePath = QDir::toNativeSeparators(QDir::tempPath() + "/data.cpp");
};
TEST_F(RefactoringCompilationDatabase, GetAllFilesContainsTranslationUnit)
{
auto filePaths = database.getAllFiles(); auto filePaths = database.getAllFiles();
ASSERT_THAT(filePaths, Contains("/tmp/data.cpp")); ASSERT_THAT(filePaths, Contains(temporarySourceFilePath));
} }
TEST(RefactoringCompilationDatabase, CompileCommandForFilePath) TEST_F(RefactoringCompilationDatabase, CompileCommandForFilePath)
{ {
RefactoringCompilationDatabase database;
database.addFile("/tmp", "data.cpp", {"cc", "data.cpp", "-DNO_DEBUG"});
auto compileCommands = database.getAllCompileCommands(); auto compileCommands = database.getAllCompileCommands();
ASSERT_THAT(compileCommands, Contains(IsCompileCommand("/tmp", ASSERT_THAT(compileCommands, Contains(IsCompileCommand(temporaryDirectoryPath,
"data.cpp", "data.cpp",
std::vector<std::string>{"cc", "data.cpp", "-DNO_DEBUG"}))); std::vector<std::string>{"cc", "data.cpp", "-DNO_DEBUG"})));
} }
TEST(RefactoringCompilationDatabase, NoCompileCommandForFilePath) TEST_F(RefactoringCompilationDatabase, NoCompileCommandForFilePath)
{ {
RefactoringCompilationDatabase database;
database.addFile("/tmp", "data.cpp", {"cc", "data.cpp", "-DNO_DEBUG"});
auto compileCommands = database.getAllCompileCommands(); auto compileCommands = database.getAllCompileCommands();
ASSERT_THAT(compileCommands, Not(Contains(IsCompileCommand("/tmp", ASSERT_THAT(compileCommands, Not(Contains(IsCompileCommand(temporaryDirectoryPath,
"data.cpp2", "data.cpp2",
std::vector<std::string>{"cc", "data.cpp", "-DNO_DEBUG"})))); std::vector<std::string>{"cc", "data.cpp", "-DNO_DEBUG"}))));
} }
TEST(RefactoringCompilationDatabase, FilePaths) TEST_F(RefactoringCompilationDatabase, FilePaths)
{ {
RefactoringCompilationDatabase database;
database.addFile("/tmp", "data.cpp", {"cc", "data.cpp", "-DNO_DEBUG"});
auto filePaths = database.getAllFiles(); auto filePaths = database.getAllFiles();
ASSERT_THAT(filePaths, Contains("/tmp/data.cpp")); ASSERT_THAT(filePaths, Contains(temporarySourceFilePath));
}
void RefactoringCompilationDatabase::SetUp()
{
database.addFile(temporaryDirectoryPath, "data.cpp", {"cc", "data.cpp", "-DNO_DEBUG"});
} }
} }