feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Simplify device setup and handling

Browse Source 
Make isLocal() less intrusively used and correct.  Use the stored device
more often, also handle errors more quickly.

Change-Id: I146d1f5788ea79d0a9d7b058c81908d451cf00d0
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
This commit is contained in:
hjk
2016-01-30 01:38:58 +01:00
parent d14257736e
commit dcfb622126
13 changed files with 41 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/valgrind/valgrindengine.h
View File

@@ -51,16 +51,13 @@ public:
QString executable() const;
void setCustomStart() { m_isCustomStart = true; }
protected:
virtual QString progressTitle() const = 0;
virtual QStringList toolArguments() const = 0;
virtual Valgrind::ValgrindRunner *runner() = 0;
ValgrindBaseSettings *m_settings;
ValgrindBaseSettings *m_settings = 0;
QFutureInterface<void> m_progress;
bool m_isCustomStart;
private:
void handleProgressCanceled();
@@ -73,7 +70,7 @@ private:
QStringList genericToolArguments() const;
private:
bool m_isStopping;
bool m_isStopping = false;
};
} // namespace Internal