feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Misc: Fix MSVC warnings

Browse Source 
C4573: the usage of 'QObject::connect' requires the compiler to capture 'this' but the current default capture mode does not allow it

and implicit conversions from size_t to int

Change-Id: If9b4ba3103cadd5b2a38ba7072d05aa1488a87bb
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Orgad Shaneh
2020-02-24 10:24:11 +02:00
committed by Orgad Shaneh
parent 9b5e642400
commit dd0efea95d
4 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/bineditor/bineditorplugin.cpp
View File

@@ -472,7 +472,7 @@ BinEditorFactory::BinEditorFactory()
setDisplayName(QCoreApplication::translate("OpenWith::Editors", Constants::C_BINEDITOR_DISPLAY_NAME)); setDisplayName(QCoreApplication::translate("OpenWith::Editors", Constants::C_BINEDITOR_DISPLAY_NAME));
addMimeType(Constants::C_BINEDITOR_MIMETYPE); addMimeType(Constants::C_BINEDITOR_MIMETYPE);
setEditorCreator([] { setEditorCreator([this] {
auto widget = new BinEditorWidget(); auto widget = new BinEditorWidget();
auto editor = new BinEditor(widget); auto editor = new BinEditor(widget);

14
src/plugins/debugger/uvsc/uvscclient.cpp
View File

@@ -321,7 +321,7 @@ bool UvscClient::fetchThreads(bool showNames, GdbMi &data)
return false; return false;
std::vector<TASKENUM> taskenums(kMaximumTaskEnumsCount); std::vector<TASKENUM> taskenums(kMaximumTaskEnumsCount);
qint32 taskenumsCount = taskenums.size(); qint32 taskenumsCount = qint32(taskenums.size());
const UVSC_STATUS st = ::UVSC_DBG_ENUM_TASKS(m_descriptor, taskenums.data(), const UVSC_STATUS st = ::UVSC_DBG_ENUM_TASKS(m_descriptor, taskenums.data(),
&taskenumsCount); &taskenumsCount);
if (st != UVSC_STATUS_SUCCESS) { if (st != UVSC_STATUS_SUCCESS) {
@@ -432,7 +432,7 @@ bool UvscClient::fetchRegisters(Registers &registers)
// Enumerate the register groups names. // Enumerate the register groups names.
std::vector<SSTR> sstrs(kMaximumRegisterGroupsCount); std::vector<SSTR> sstrs(kMaximumRegisterGroupsCount);
qint32 sstrsCount = sstrs.size(); qint32 sstrsCount = qint32(sstrs.size());
UVSC_STATUS st = ::UVSC_DBG_ENUM_REGISTER_GROUPS(m_descriptor, sstrs.data(), UVSC_STATUS st = ::UVSC_DBG_ENUM_REGISTER_GROUPS(m_descriptor, sstrs.data(),
&sstrsCount); &sstrsCount);
if (st != UVSC_STATUS_SUCCESS) { if (st != UVSC_STATUS_SUCCESS) {
@@ -449,7 +449,7 @@ bool UvscClient::fetchRegisters(Registers &registers)
// Enumerate the registers. // Enumerate the registers.
std::vector<REGENUM> regenums(kMaximumRegisterEnumsCount); std::vector<REGENUM> regenums(kMaximumRegisterEnumsCount);
qint32 regenumsCount = regenums.size(); qint32 regenumsCount = qint32(regenums.size());
st = ::UVSC_DBG_ENUM_REGISTERS(m_descriptor, regenums.data(), &regenumsCount); st = ::UVSC_DBG_ENUM_REGISTERS(m_descriptor, regenums.data(), &regenumsCount);
if (st != UVSC_STATUS_SUCCESS) { if (st != UVSC_STATUS_SUCCESS) {
setError(RuntimeError); setError(RuntimeError);
@@ -471,7 +471,7 @@ bool UvscClient::fetchRegisters(Registers &registers)
// Read the register values. // Read the register values.
std::vector<qint8> values(kMaximumRegisterEnumsCount * kMaximumValueBitsSize); std::vector<qint8> values(kMaximumRegisterEnumsCount * kMaximumValueBitsSize);
qint32 length = values.size(); qint32 length = qint32(values.size());
st = ::UVSC_DBG_READ_REGISTERS( m_descriptor, values.data(), &length); st = ::UVSC_DBG_READ_REGISTERS( m_descriptor, values.data(), &length);
if (st != UVSC_STATUS_SUCCESS) { if (st != UVSC_STATUS_SUCCESS) {
setError(RuntimeError); setError(RuntimeError);
@@ -529,7 +529,7 @@ bool UvscClient::inspectLocal(const QStringList &expandedLocalINames,
ivarenum.frame = frameId; ivarenum.frame = frameId;
ivarenum.count = kMaximumVarinfosCount / 2; ivarenum.count = kMaximumVarinfosCount / 2;
std::vector<VARINFO> varinfos(kMaximumVarinfosCount); std::vector<VARINFO> varinfos(kMaximumVarinfosCount);
qint32 varinfosCount = varinfos.size(); qint32 varinfosCount = qint32(varinfos.size());
const UVSC_STATUS st = ::UVSC_DBG_ENUM_VARIABLES(m_descriptor, &ivarenum, const UVSC_STATUS st = ::UVSC_DBG_ENUM_VARIABLES(m_descriptor, &ivarenum,
varinfos.data(), &varinfosCount); varinfos.data(), &varinfosCount);
if (st != UVSC_STATUS_SUCCESS) { if (st != UVSC_STATUS_SUCCESS) {
@@ -647,7 +647,7 @@ bool UvscClient::inspectWatcher(const QStringList &expandedWatcherINames,
ivarenum.id = watcherId; ivarenum.id = watcherId;
ivarenum.count = kMaximumVarinfosCount / 2; ivarenum.count = kMaximumVarinfosCount / 2;
std::vector<VARINFO> varinfos(kMaximumVarinfosCount); std::vector<VARINFO> varinfos(kMaximumVarinfosCount);
qint32 varinfosCount = varinfos.size(); qint32 varinfosCount = qint32(varinfos.size());
const UVSC_STATUS st = ::UVSC_DBG_ENUM_VARIABLES(m_descriptor, &ivarenum, const UVSC_STATUS st = ::UVSC_DBG_ENUM_VARIABLES(m_descriptor, &ivarenum,
varinfos.data(), &varinfosCount); varinfos.data(), &varinfosCount);
if (st != UVSC_STATUS_SUCCESS) { if (st != UVSC_STATUS_SUCCESS) {
@@ -1027,7 +1027,7 @@ bool UvscClient::enumerateStack(quint32 taskId, std::vector<STACKENUM> &stackenu
istkenum.isFull = true; istkenum.isFull = true;
istkenum.hasExtended = true; istkenum.hasExtended = true;
stackenums.resize(kMaximumStackEnumsCount); stackenums.resize(kMaximumStackEnumsCount);
qint32 stackenumsCount = stackenums.size(); qint32 stackenumsCount = qint32(stackenums.size());
const UVSC_STATUS st = ::UVSC_DBG_ENUM_STACK(m_descriptor, &istkenum, const UVSC_STATUS st = ::UVSC_DBG_ENUM_STACK(m_descriptor, &istkenum,
stackenums.data(), &stackenumsCount); stackenums.data(), &stackenumsCount);
if (st != UVSC_STATUS_SUCCESS) if (st != UVSC_STATUS_SUCCESS)

2
src/plugins/git/giteditor.cpp
View File

@@ -66,7 +66,7 @@ class GitLogFilterWidget : public QToolBar
public: public:
GitLogFilterWidget(GitEditorWidget *editor) GitLogFilterWidget(GitEditorWidget *editor)
{ {
auto addLineEdit = [](const QString &placeholder, auto addLineEdit = [this](const QString &placeholder,
const QString &tooltip, const QString &tooltip,
GitEditorWidget *editor) GitEditorWidget *editor)
{ {

4
src/plugins/perfprofiler/perfprofilerflamegraphmodel.cpp
View File

@@ -152,9 +152,9 @@ int PerfProfilerFlameGraphModel::rowCount(const QModelIndex &parent) const
{ {
if (parent.isValid()) { if (parent.isValid()) {
Data *parentData = static_cast<Data *>(parent.internalPointer()); Data *parentData = static_cast<Data *>(parent.internalPointer());
return parentData->children.size(); return int(parentData->children.size());
} }
return m_stackBottom->children.size(); return int(m_stackBottom->children.size());
} }
int PerfProfilerFlameGraphModel::columnCount(const QModelIndex &parent) const int PerfProfilerFlameGraphModel::columnCount(const QModelIndex &parent) const