From ddde374b4013af74dc1238e3b77612f60bf478b9 Mon Sep 17 00:00:00 2001
From: Henning Gruendl <henning.gruendl@qt.io>
Date: Mon, 29 Jun 2020 12:01:15 +0200
Subject: [PATCH] QmlDesigner: Set height according to active tab

* Add binding to current tab height
* Remove unused specficsOneHeight statement

Task-number: QDS-2051
Change-Id: Ia1ac6af4e65d3de5e1db96f2bcc2d1ec8eb08312
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
---
 .../QtQuick/ItemPane.qml                        | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml b/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml
index 41abe776cec..25b0d498548 100644
--- a/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml
+++ b/share/qtcreator/qmldesigner/propertyEditorQmlSources/QtQuick/ItemPane.qml
@@ -325,12 +325,10 @@ Rectangle {
                 frameVisible: false
 
                 id: tabView
-                height: Math.max(layoutSectionHeight, specficsHeight, advancedHeight) + extraHeight
 
-                property int advancedHeight: 0
-                property int layoutSectionHeight: 0
-                property int specficsHeight: 0
+                height: currentHeight + extraHeight
 
+                property int currentHeight: getTab(currentIndex).item.implicitHeight
                 property int extraHeight: 40
 
                 Tab {
@@ -340,8 +338,6 @@ Rectangle {
                         anchors.left: parent.left
                         anchors.right: parent.right
 
-                        onImplicitHeightChanged: tabView.specficsHeight = implicitHeight
-
                         Loader {
                             anchors.left: parent.left
                             anchors.right: parent.right
@@ -366,11 +362,6 @@ Rectangle {
                             source: specificsUrl;
 
                             property int loaderHeight: specificsOne.item.height + tabView.extraHeight
-                            onLoaderHeightChanged: tabView.specficsOneHeight = loaderHeight
-
-                            onLoaded: {
-                                tabView.specficsOneHeight = loaderHeight
-                            }
                         }
                     }
                 }
@@ -381,8 +372,6 @@ Rectangle {
                         anchors.left: parent.left
                         anchors.right: parent.right
 
-                        onImplicitHeightChanged: tabView.layoutSectionHeight = implicitHeight
-
                         LayoutSection {
                         }
 
@@ -713,8 +702,6 @@ Rectangle {
                         anchors.left: parent.left
                         anchors.right: parent.right
 
-                        onImplicitHeightChanged: tabView.advancedHeight = implicitHeight
-
                         AdvancedSection {
                         }
                         LayerSection {