feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Avoid duplicates in circular clipboard.

Browse Source 
When data is added to the circular, first check if it is already
present. In that case, the item is moved to the beginning of the
circular clipboard.

This avoids dropping old data prematurly, and traversing the same data
multiple times when pasting.

Change-Id: Iecaf8d2f5a05d08e6f5faa8555d24f4d7a1d33ab
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
This commit is contained in:
Francois Ferrand
2012-03-12 17:34:07 +01:00
committed by Leandro Melo
parent 0cfff86753
commit de0fcfaa0a
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/texteditor/circularclipboard.cpp
View File

@@ -53,6 +53,16 @@ CircularClipboard *CircularClipboard::instance()
void CircularClipboard::collect(const QMimeData *mimeData) void CircularClipboard::collect(const QMimeData *mimeData)
{ {
//Avoid duplicates
const QString text = mimeData->text();
for (QList<const QMimeData *>::iterator i = m_items.begin(); i != m_items.end(); ++i) {
if (mimeData == *i || text == (*i)->text()) {
if (mimeData != *i)
delete *i;
m_items.erase(i);
break;
}
}
if (m_items.size() > kMaxSize) { if (m_items.size() > kMaxSize) {
delete m_items.last(); delete m_items.last();
m_items.removeLast(); m_items.removeLast();