From 6e2f8a83d1c72d12e91ed871899612093f9fd2c7 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 2 Mar 2015 15:52:44 +0100 Subject: [PATCH 1/3] Remove experimental state Change-Id: I8b66e228dff39db37b66270fec39ca526b6373a0 Reviewed-by: Christian Kandeler --- plugins/clangstaticanalyzer/ClangStaticAnalyzer.json.in | 1 - 1 file changed, 1 deletion(-) diff --git a/plugins/clangstaticanalyzer/ClangStaticAnalyzer.json.in b/plugins/clangstaticanalyzer/ClangStaticAnalyzer.json.in index 081dc1eef65..fc86ed513b3 100644 --- a/plugins/clangstaticanalyzer/ClangStaticAnalyzer.json.in +++ b/plugins/clangstaticanalyzer/ClangStaticAnalyzer.json.in @@ -2,7 +2,6 @@ \"Name\" : \"ClangStaticAnalyzer\", \"Version\" : \"$$QTCREATOR_VERSION\", \"CompatVersion\" : \"$$QTCREATOR_COMPAT_VERSION\", - \"Experimental\" : true, \"Vendor\" : \"The Qt Company Ltd\", \"Copyright\" : \"(C) 2015 The Qt Company Ltd\", \"License\" : [ \"Commercial Usage\", From d2fa3e9902c31db2fc72e20c1641c29cc512013d Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 2 Mar 2015 15:51:28 +0100 Subject: [PATCH 2/3] Add changes-3.4.0 Change-Id: Idfd70d71a3290f4c3e9968f2882e7a671f8995d8 Reviewed-by: Christian Kandeler Reviewed-by: Riitta-Leena Miettinen --- dist/changes-3.4.0 | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 dist/changes-3.4.0 diff --git a/dist/changes-3.4.0 b/dist/changes-3.4.0 new file mode 100644 index 00000000000..894f4b0fea8 --- /dev/null +++ b/dist/changes-3.4.0 @@ -0,0 +1,7 @@ +Clang Static Analyzer 3.4.0 + +* Removed experimental state +* Added support for MSVC (requires Clang 3.6 or later) +* Added support for MinGW +* Added support for suppressing diagnostics + (added tool button in diagnostics view, and option pane in Projects mode) From 5b1a7f37560d24821e9bea705aaba26f71b604ab Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 4 Mar 2015 17:33:06 +0100 Subject: [PATCH 3/3] Use new AnalyzerUtils::logToIssuesPane(). Change-Id: I9820a81f67c06b7bb54720772467263bfa9fc8f3 Reviewed-by: Andre Poenitz --- .../clangstaticanalyzerruncontrol.cpp | 22 ++++++------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp b/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp index e0576299e46..c99060d13c2 100644 --- a/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp +++ b/plugins/clangstaticanalyzer/clangstaticanalyzerruncontrol.cpp @@ -23,8 +23,8 @@ #include "clangstaticanalyzersettings.h" #include "clangstaticanalyzerutils.h" -#include #include +#include #include @@ -53,14 +53,6 @@ static Q_LOGGING_CATEGORY(LOG, "qtc.clangstaticanalyzer.runcontrol") namespace ClangStaticAnalyzer { namespace Internal { -static void logToIssuesPane(Task::TaskType type, const QString &message) -{ - TaskHub::addTask(type, message, Analyzer::Constants::ANALYZERTASK_ID); - if (type == Task::Error) - TaskHub::requestPopup(); -} - - ClangStaticAnalyzerRunControl::ClangStaticAnalyzerRunControl( const Analyzer::AnalyzerStartParameters &startParams, ProjectExplorer::RunConfiguration *runConfiguration, @@ -204,7 +196,7 @@ bool ClangStaticAnalyzerRunControl::startEngine() const QString errorMessage = tr("Clang Static Analyzer: Invalid executable \"%1\", stop.") .arg(executable); appendMessage(errorMessage + QLatin1Char('\n'), Utils::ErrorMessageFormat); - logToIssuesPane(Task::Error, errorMessage); + AnalyzerUtils::logToIssuesPane(Task::Error, errorMessage); emit finished(); return false; } @@ -217,7 +209,7 @@ bool ClangStaticAnalyzerRunControl::startEngine() const QString errorMessage = tr("Clang Static Analyzer: Failed to create temporary dir, stop."); appendMessage(errorMessage + QLatin1Char('\n'), Utils::ErrorMessageFormat); - logToIssuesPane(Task::Error, errorMessage); + AnalyzerUtils::logToIssuesPane(Task::Error, errorMessage); emit finished(); return false; } @@ -287,8 +279,8 @@ void ClangStaticAnalyzerRunControl::analyzeNextFile() + QLatin1Char('\n'), Utils::NormalMessageFormat); if (m_filesAnalyzed == 0 && m_filesNotAnalyzed != 0) { - logToIssuesPane(Task::Error, - tr("Clang Static Analyzer: Failed to analyze any files.")); + AnalyzerUtils::logToIssuesPane(Task::Error, + tr("Clang Static Analyzer: Failed to analyze any files.")); } m_progress.reportFinished(); emit finished(); @@ -353,8 +345,8 @@ void ClangStaticAnalyzerRunControl::onRunnerFinishedWithFailure(const QString &e + QLatin1Char('\n') , Utils::StdErrFormat); appendMessage(errorDetails, Utils::StdErrFormat); - logToIssuesPane(Task::Warning, errorMessage); - logToIssuesPane(Task::Warning, errorDetails); + AnalyzerUtils::logToIssuesPane(Task::Warning, errorMessage); + AnalyzerUtils::logToIssuesPane(Task::Warning, errorDetails); handleFinished(); }