From decbb93069d41dba0334345729c94c8a0f8db78c Mon Sep 17 00:00:00 2001 From: David Schulz Date: Wed, 23 Nov 2022 07:28:12 +0100 Subject: [PATCH] MsvcToolChain: reduce severity of task for failed vcvars runs ... if we can use cached environment modifications from previous Qt Creator runs. Change-Id: I2c570f3d3fc30adccf27339b2e21c5d00d4caa37 Reviewed-by: Qt CI Bot Reviewed-by: Christian Stenger --- src/plugins/projectexplorer/msvctoolchain.cpp | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/src/plugins/projectexplorer/msvctoolchain.cpp b/src/plugins/projectexplorer/msvctoolchain.cpp index 5bb3fe8d077..d6c1ba9b574 100644 --- a/src/plugins/projectexplorer/msvctoolchain.cpp +++ b/src/plugins/projectexplorer/msvctoolchain.cpp @@ -8,6 +8,7 @@ #include "projectexplorer.h" #include "projectexplorerconstants.h" #include "projectexplorersettings.h" +#include "projectexplorertr.h" #include "taskhub.h" #include @@ -776,9 +777,19 @@ void MsvcToolChain::initEnvModWatcher(const QFuture &future) QObject::connect(&m_envModWatcher, &QFutureWatcher::resultReadyAt, [&]() { const GenerateEnvResult &result = m_envModWatcher.result(); if (result.error) { - const QString &errorMessage = *result.error; - if (!errorMessage.isEmpty()) - TaskHub::addTask(CompileTask(Task::Error, errorMessage)); + QString errorMessage = *result.error; + if (!errorMessage.isEmpty()) { + Task::TaskType severity; + if (m_environmentModifications.isEmpty()) { + severity = Task::Error; + } else { + severity = Task::Warning; + errorMessage.prepend( + Tr::tr("Falling back to use the cached environment for \"%1\" after:") + .arg(displayName()) + '\n'); + } + TaskHub::addTask(CompileTask(severity, errorMessage)); + } } else { updateEnvironmentModifications(result.environmentItems); }