ProjectExplorer: Use override consistently

clang-tidy fixes from modernize-use-override check.

Change-Id: I216701aec0b4134321e220f9e599e053a8e22945
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Tobias Hunger
2018-05-07 14:58:16 +02:00
parent 91c19ab19d
commit dee0207034
14 changed files with 19 additions and 19 deletions

View File

@@ -122,7 +122,7 @@ class PROJECTEXPLORER_EXPORT IBuildConfigurationFactory : public QObject
protected:
IBuildConfigurationFactory();
~IBuildConfigurationFactory();
~IBuildConfigurationFactory() override;
public:
// The priority is negative if this factory can not create anything for the target.

View File

@@ -124,7 +124,7 @@ class PROJECTEXPLORER_EXPORT BuildStepFactory : public QObject
public:
BuildStepFactory();
~BuildStepFactory();
~BuildStepFactory() override;
static const QList<BuildStepFactory *> allBuildStepFactories();
@@ -191,9 +191,9 @@ public:
this, &BuildStepConfigWidget::updateSummary);
}
QString summaryText() const { return QLatin1String("<b>") + displayName() + QLatin1String("</b>"); }
QString displayName() const { return m_step->displayName(); }
bool showWidget() const { return false; }
QString summaryText() const override { return QLatin1String("<b>") + displayName() + QLatin1String("</b>"); }
QString displayName() const override { return m_step->displayName(); }
bool showWidget() const override { return false; }
BuildStep *step() const { return m_step; }
private:

View File

@@ -81,8 +81,8 @@ public:
Target *target() const;
Project *project() const override;
virtual QVariantMap toMap() const override;
virtual bool fromMap(const QVariantMap &map) override;
QVariantMap toMap() const override;
bool fromMap(const QVariantMap &map) override;
bool isActive() const override;

View File

@@ -38,7 +38,7 @@ class PROJECTEXPLORER_EXPORT ClangParser : public ProjectExplorer::GccParser
public:
ClangParser();
void stdError(const QString &line);
void stdError(const QString &line) override;
static Core::Id id();

View File

@@ -56,7 +56,7 @@ class PROJECTEXPLORER_EXPORT ICustomWizardMetaFactory : public QObject
public:
ICustomWizardMetaFactory(const QString &klass, Core::IWizardFactory::WizardKind kind);
~ICustomWizardMetaFactory();
~ICustomWizardMetaFactory() override;
virtual CustomWizard *create() const = 0;
QString klass() const { return m_klass; }

View File

@@ -44,7 +44,7 @@ class PROJECTEXPLORER_EXPORT IDeviceFactory : public QObject
Q_OBJECT
public:
~IDeviceFactory();
~IDeviceFactory() override;
static const QList<IDeviceFactory *> allDeviceFactories();
virtual QString displayNameForId(Core::Id type) const = 0;

View File

@@ -99,7 +99,7 @@ public:
ProcessExtraCompiler(const Project *project, const Utils::FileName &source,
const Utils::FileNameList &targets, QObject *parent = nullptr);
~ProcessExtraCompiler();
~ProcessExtraCompiler() override;
protected:
// This will run a process in a thread, if
@@ -141,7 +141,7 @@ class PROJECTEXPLORER_EXPORT ExtraCompilerFactory : public QObject
Q_OBJECT
public:
explicit ExtraCompilerFactory(QObject *parent = nullptr);
~ExtraCompilerFactory();
~ExtraCompilerFactory() override;
virtual FileType sourceType() const = 0;
virtual QString sourceTag() const = 0;

View File

@@ -283,7 +283,7 @@ public:
void addToEnvironment(Utils::Environment &env) const override;
protected:
virtual CompilerFlags defaultCompilerFlags() const override;
CompilerFlags defaultCompilerFlags() const override;
private:
friend class Internal::ClangToolChainFactory;

View File

@@ -163,7 +163,7 @@ public:
ItemList toUserOutput(const Kit *k) const override;
virtual void addToMacroExpander(ProjectExplorer::Kit *kit, Utils::MacroExpander *expander) const override;
void addToMacroExpander(ProjectExplorer::Kit *kit, Utils::MacroExpander *expander) const override;
static Core::Id id();
static IDevice::ConstPtr device(const Kit *k);

View File

@@ -46,7 +46,7 @@ protected:
explicit ProjectConfiguration(QObject *parent, Core::Id id);
public:
~ProjectConfiguration() = default;
~ProjectConfiguration() override = default;
Core::Id id() const;

View File

@@ -51,7 +51,7 @@ public:
};
ProjectImporter(const Utils::FileName &path);
virtual ~ProjectImporter();
~ProjectImporter() override;
const Utils::FileName projectFilePath() const { return m_projectPath; }
const Utils::FileName projectDirectory() const { return m_projectPath.parentDir(); }

View File

@@ -48,7 +48,7 @@ class PROJECTEXPLORER_EXPORT ProjectTree : public QObject
Q_OBJECT
public:
explicit ProjectTree(QObject *parent = nullptr);
~ProjectTree();
~ProjectTree() override;
static ProjectTree *instance();

View File

@@ -56,7 +56,7 @@ class ProjectWindow : public Utils::FancyMainWindow
public:
ProjectWindow();
~ProjectWindow();
~ProjectWindow() override;
private:
ProjectWindowPrivate *d;

View File

@@ -180,7 +180,7 @@ class PROJECTEXPLORER_EXPORT ToolChainFactory : public QObject
public:
ToolChainFactory();
~ToolChainFactory();
~ToolChainFactory() override;
static const QList<ToolChainFactory *> allToolChainFactories();