feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Terminal: Improve paste performance

Browse Source 
Pasting large amounts of data on macos would block the App indefinitely.

The issue was a blocking call to ::write. The first fix for that was to
set O_NONBLOCK on the tty stdout fd. The second fix was to pass the
actual result of the write back to the caller so they can react to it.

In the TerminalSurface we now check if the write was successful and
if not we buffer the data and try again later.

Change-Id: Ibc92cce57fad88b5e9aa325197b42e17bec5e746
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-07-25 08:17:13 +02:00
parent 5e5b90a9a1
commit def291f260
6 changed files with 84 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/terminal/terminalwidget.h
View File

@@ -129,7 +129,7 @@ protected:
void setupColors();
void setupActions();
void writeToPty(const QByteArray &data);
qint64 writeToPty(const QByteArray &data);
int paintCell(QPainter &p,
const QRectF &cellRect,