feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BareMetal: More inlining of simple functions

Browse Source 
Change-Id: I88413413a4db9a599ed673a818fb8947224605ae
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2023-07-20 18:14:03 +02:00
parent 0137c7f8b6
commit df0a3e2a85
2 changed files with 3 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/baremetal/iarewtoolchain.cpp
View File

@@ -301,7 +301,7 @@ public:
BuiltInHeaderPathsRunner createBuiltInHeaderPathsRunner(const Environment &) const final; BuiltInHeaderPathsRunner createBuiltInHeaderPathsRunner(const Environment &) const final;
void addToEnvironment(Environment &env) const final; void addToEnvironment(Environment &env) const final;
QList<OutputLineParser *> createOutputParsers() const final; QList<OutputLineParser *> createOutputParsers() const final { return {new IarParser()}; }
std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() final; std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() final;
@@ -389,11 +389,6 @@ void IarToolChain::addToEnvironment(Environment &env) const
env.prependOrSetPath(compilerCommand().parentDir()); env.prependOrSetPath(compilerCommand().parentDir());
} }
QList<Utils::OutputLineParser *> IarToolChain::createOutputParsers() const
{
return {new IarParser()};
}
std::unique_ptr<ToolChainConfigWidget> IarToolChain::createConfigurationWidget() std::unique_ptr<ToolChainConfigWidget> IarToolChain::createConfigurationWidget()
{ {
return std::make_unique<IarToolChainConfigWidget>(this); return std::make_unique<IarToolChainConfigWidget>(this);

15
src/plugins/baremetal/sdcctoolchain.cpp
View File

@@ -216,13 +216,13 @@ public:
BuiltInHeaderPathsRunner createBuiltInHeaderPathsRunner(const Environment &) const final; BuiltInHeaderPathsRunner createBuiltInHeaderPathsRunner(const Environment &) const final;
void addToEnvironment(Environment &env) const final; void addToEnvironment(Environment &env) const final;
QList<OutputLineParser *> createOutputParsers() const final; QList<OutputLineParser *> createOutputParsers() const final { return {new SdccParser}; }
std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() final; std::unique_ptr<ToolChainConfigWidget> createConfigurationWidget() final;
bool operator==(const ToolChain &other) const final; bool operator==(const ToolChain &other) const final;
FilePath makeCommand(const Environment &env) const final; FilePath makeCommand(const Environment &) const final { return {}; }
private: private:
friend class SdccToolChainFactory; friend class SdccToolChainFactory;
@@ -283,11 +283,6 @@ void SdccToolChain::addToEnvironment(Environment &env) const
env.prependOrSetPath(compilerCommand().parentDir()); env.prependOrSetPath(compilerCommand().parentDir());
} }
QList<Utils::OutputLineParser *> SdccToolChain::createOutputParsers() const
{
return {new SdccParser};
}
std::unique_ptr<ToolChainConfigWidget> SdccToolChain::createConfigurationWidget() std::unique_ptr<ToolChainConfigWidget> SdccToolChain::createConfigurationWidget()
{ {
return std::make_unique<SdccToolChainConfigWidget>(this); return std::make_unique<SdccToolChainConfigWidget>(this);
@@ -303,12 +298,6 @@ bool SdccToolChain::operator==(const ToolChain &other) const
&& targetAbi() == customTc->targetAbi(); && targetAbi() == customTc->targetAbi();
} }
FilePath SdccToolChain::makeCommand(const Environment &env) const
{
Q_UNUSED(env)
return {};
}
// SdccToolChainFactory // SdccToolChainFactory
SdccToolChainFactory::SdccToolChainFactory() SdccToolChainFactory::SdccToolChainFactory()