From df3ace009ac0371610337e8efee0299469b0ef6a Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Mon, 9 Jan 2023 13:49:41 +0200 Subject: [PATCH] QmlDesigner: Fix clearing node lock/eyeball Lock/eyeball status was not propagated to puppet when lock/eyeball was cleared, as clearing these aux properties instead removes them, which triggers change notification with invalid value. Fixed by allowing invalid value to be propagated for these properties. Fixes: QDS-8735 Change-Id: Ic5c4818afeef71612f9620b3a0af503793a37e90 Reviewed-by: Mahmoud Badri --- .../designercore/instances/nodeinstanceview.cpp | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp index c715b659787..ed8436d6a0b 100644 --- a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp +++ b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp @@ -640,14 +640,12 @@ void NodeInstanceView::auxiliaryDataChanged(const ModelNode &node, case AuxiliaryDataType::Document: if ((key == lockedProperty || key == invisibleProperty) && hasInstanceForModelNode(node)) { NodeInstance instance = instanceForModelNode(node); - if (value.isValid()) { - PropertyValueContainer container{instance.instanceId(), - PropertyName{key.name}, - value, - TypeName(), - key.type}; - m_nodeInstanceServer->changeAuxiliaryValues({{container}}); - } + PropertyValueContainer container{instance.instanceId(), + PropertyName{key.name}, + value, + TypeName(), + key.type}; + m_nodeInstanceServer->changeAuxiliaryValues({{container}}); }; break;