feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use Core::Id in project-related objects

Browse Source 
Use Core::Id for all the project related objects in favor of plain
QStrings.

Change-Id: I790ab40cb29899efdb49c413a77609486f52e683
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
This commit is contained in:
Tobias Hunger
2012-03-15 17:17:40 +01:00
parent cf26765c62
commit df5dab6382
217 changed files with 1379 additions and 1357 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/projectexplorer/runsettingspropertiespage.cpp
View File

@@ -67,7 +67,7 @@ namespace Internal {
struct FactoryAndId
{
ProjectExplorer::IRunConfigurationFactory *factory;
QString id;
Core::Id id;
};
@@ -268,8 +268,8 @@ void RunSettingsWidget::aboutToShowAddMenu()
QList<IRunConfigurationFactory *> factories =
ExtensionSystem::PluginManager::instance()->getObjects<IRunConfigurationFactory>();
foreach (IRunConfigurationFactory *factory, factories) {
QStringList ids = factory->availableCreationIds(m_target);
foreach (const QString &id, ids) {
QList<Core::Id> ids = factory->availableCreationIds(m_target);
foreach (Core::Id id, ids) {
QAction *action = m_addRunMenu->addAction(factory->displayNameForId(id));;
FactoryAndId fai;
fai.factory = factory;
@@ -370,10 +370,10 @@ void RunSettingsWidget::currentDeployConfigurationChanged(int index)
void RunSettingsWidget::aboutToShowDeployMenu()
{
m_addDeployMenu->clear();
QStringList ids = m_target->availableDeployConfigurationIds();
foreach (const QString &id, ids) {
QList<Core::Id> ids = m_target->availableDeployConfigurationIds();
foreach (Core::Id id, ids) {
QAction *action = m_addDeployMenu->addAction(m_target->displayNameForDeployConfigurationId(id));
action->setData(QVariant(id));
action->setData(QVariant::fromValue(id));
connect(action, SIGNAL(triggered()),
this, SLOT(addDeployConfiguration()));
}
@@ -384,7 +384,7 @@ void RunSettingsWidget::addDeployConfiguration()
QAction *act = qobject_cast<QAction *>(sender());
if (!act)
return;
QString id = act->data().toString();
Core::Id id = act->data().value<Core::Id>();
DeployConfiguration *newDc = m_target->createDeployConfiguration(id);
if (!newDc)
return;