feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Wizards: Do some input validation on repository URLs

Browse Source 
Fixes: QTCREATORBUG-18935
Change-Id: Ie2103cbe2899ea23caaedd4a6350c78b5f380ab9
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Christian Kandeler
2019-07-23 16:15:57 +02:00
parent 00bdb007ee
commit df8ef72aec
13 changed files with 95 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/plugins/coreplugin/iversioncontrol.cpp
View File

@@ -26,9 +26,12 @@
#include "iversioncontrol.h"
#include "vcsmanager.h"
#include <utils/hostosinfo.h>
#include <utils/qtcassert.h>
#include <QDir>
#include <QFileInfo>
#include <QRegularExpression>
#include <QStringList>
/*!
@@ -90,6 +93,50 @@ ShellCommand *IVersionControl::createInitialCheckoutCommand(const QString &url,
return nullptr;
}
IVersionControl::RepoUrl::RepoUrl(const QString &location)
{
if (location.isEmpty())
return;
// Check for local remotes (refer to the root or relative path)
// On Windows, local paths typically starts with <drive>:
auto locationIsOnWindowsDrive = [&location] {
if (!Utils::HostOsInfo::isWindowsHost() || location.size() < 2)
return false;
const QChar drive = location.at(0).toLower();
return drive >= 'a' && drive <= 'z' && location.at(1) == ':';
};
if (location.startsWith("file://") || location.startsWith('/') || location.startsWith('.')
|| locationIsOnWindowsDrive()) {
protocol = "file";
path = QDir::fromNativeSeparators(location.startsWith("file://")
? location.mid(7) : location);
isValid = true;
return;
}
// TODO: Why not use QUrl?
static const QRegularExpression remotePattern(
"^(?:(?<protocol>[^:]+)://)?(?:(?<user>[^@]+)@)?(?<host>[^:/]+)"
"(?::(?<port>\\d+))?:?(?<path>.*)$");
const QRegularExpressionMatch match = remotePattern.match(location);
if (!match.hasMatch())
return;
bool ok = false;
protocol = match.captured("protocol");
userName = match.captured("user");
host = match.captured("host");
port = match.captured("port").toUShort(&ok);
path = match.captured("path");
isValid = !host.isEmpty() && (ok || match.captured("port").isEmpty());
}
IVersionControl::RepoUrl IVersionControl::getRepoUrl(const QString &location) const
{
return RepoUrl(location);
}
QString IVersionControl::vcsTopic(const QString &topLevel)
{
return m_topicCache ? m_topicCache->topic(topLevel) : QString();