feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AbstractProcessStep: Merge virtual functions

Browse Source 
Merge processSucceeded with processFinished into one virtual
function. Leave default implementation empty, so that
reimplementations don't need to call base impl. Move
processFinished into private section. Pass just one bool success
parameter into processFinished.

Change-Id: Ide3e262de0c0c5583c9fec2426fa460b6b74a49d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2022-12-02 11:33:28 +01:00
parent d8bd889eee
commit dfd079f050
8 changed files with 29 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmakeprojectmanager/qmakestep.cpp
View File

@@ -300,13 +300,11 @@ void QMakeStep::processStartupFailed()
AbstractProcessStep::processStartupFailed();
}
bool QMakeStep::processSucceeded(int exitCode, QProcess::ExitStatus status)
void QMakeStep::processFinished(bool success)
{
bool result = AbstractProcessStep::processSucceeded(exitCode, status);
if (!result)
if (!success)
m_needToRunQMake = true;
emit buildConfiguration()->buildDirectoryInitialized();
return result;
}
void QMakeStep::finish(bool success)