feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify IRunConfigurationFactory::clone() use

Browse Source 
Change-Id: I005d6c87142d26dfc7ae1349329737a68f54c427
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
hjk
2017-11-10 15:43:23 +01:00
parent 5483d45e5e
commit dfd4ad8c2d
27 changed files with 55 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/ios/iosrunfactories.cpp
View File

@@ -64,7 +64,8 @@ static Utils::FileName pathFromId(Core::Id id)
IosRunConfigurationFactory::IosRunConfigurationFactory(QObject *parent)
: QmakeRunConfigurationFactory(parent)
{
setObjectName(QLatin1String("IosRunConfigurationFactory"));
setObjectName("IosRunConfigurationFactory");
registerRunConfiguration<IosRunConfiguration>();
}
bool IosRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
@@ -103,14 +104,6 @@ QString IosRunConfigurationFactory::displayNameForId(Core::Id id) const
return pathFromId(id).toFileInfo().completeBaseName();
}
RunConfiguration *IosRunConfigurationFactory::clone(Target *parent, RunConfiguration *source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<IosRunConfiguration>(parent, source);
}
bool IosRunConfigurationFactory::canHandle(Target *t) const
{
if (!t->project()->supportsKit(t->kit()))

2
src/plugins/ios/iosrunfactories.h
View File

@@ -52,8 +52,6 @@ public:
bool canClone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) override;
bool canHandle(ProjectExplorer::Target *t) const override;
QList<ProjectExplorer::RunConfiguration *> runConfigurationsForNode(ProjectExplorer::Target *t,