feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify IRunConfigurationFactory::clone() use

Browse Source 
Change-Id: I005d6c87142d26dfc7ae1349329737a68f54c427
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
hjk
2017-11-10 15:43:23 +01:00
parent 5483d45e5e
commit dfd4ad8c2d
27 changed files with 55 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/baremetal/baremetalrunconfigurationfactory.cpp
View File

@@ -63,7 +63,8 @@ static bool canHandle(const Target *target)
BareMetalRunConfigurationFactory::BareMetalRunConfigurationFactory(QObject *parent) :
IRunConfigurationFactory(parent)
{
setObjectName(QLatin1String("BareMetalRunConfigurationFactory"));
setObjectName("BareMetalRunConfigurationFactory");
registerRunConfiguration<BareMetalRunConfiguration>();
}
bool BareMetalRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
@@ -116,12 +117,6 @@ RunConfiguration *BareMetalRunConfigurationFactory::doRestore(Target *parent, co
return doCreate(parent,Core::Id(BareMetalRunConfiguration::IdPrefix));
}
RunConfiguration *BareMetalRunConfigurationFactory::clone(Target *parent, RunConfiguration *source)
{
QTC_ASSERT(canClone(parent, source), return 0);
return cloneHelper<BareMetalRunConfiguration>(parent, source);
}
// BareMetalCustomRunConfigurationFactory
@@ -129,6 +124,7 @@ BareMetalCustomRunConfigurationFactory::BareMetalCustomRunConfigurationFactory(Q
IRunConfigurationFactory(parent)
{
setObjectName("BareMetalCustomRunConfigurationFactory");
registerRunConfiguration<BareMetalCustomRunConfiguration>();
}
bool BareMetalCustomRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
@@ -178,11 +174,5 @@ RunConfiguration *BareMetalCustomRunConfigurationFactory::doRestore(Target *pare
return new BareMetalCustomRunConfiguration(parent);
}
RunConfiguration *BareMetalCustomRunConfigurationFactory::clone(Target *parent, RunConfiguration *source)
{
QTC_ASSERT(canClone(parent, source), return 0);
return cloneHelper<BareMetalCustomRunConfiguration>(parent, source);
}
} // namespace Internal
} // namespace BareMetal

10
src/plugins/baremetal/baremetalrunconfigurationfactory.h
View File

@@ -41,12 +41,9 @@ public:
QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const override;
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) override;
private:
ProjectExplorer::RunConfiguration *doCreate(ProjectExplorer::Target *parent, Core::Id id) override;
ProjectExplorer::RunConfiguration *doRestore(ProjectExplorer::Target *parent,
@@ -64,12 +61,9 @@ public:
QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const override;
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) override;
private:
ProjectExplorer::RunConfiguration *doCreate(ProjectExplorer::Target *parent, Core::Id id) override;
ProjectExplorer::RunConfiguration *doRestore(ProjectExplorer::Target *parent,

12
src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp
View File

@@ -213,7 +213,10 @@ CMakeRunConfigurationWidget::CMakeRunConfigurationWidget(CMakeRunConfiguration *
// Factory
CMakeRunConfigurationFactory::CMakeRunConfigurationFactory(QObject *parent) :
IRunConfigurationFactory(parent)
{ setObjectName(QLatin1String("CMakeRunConfigurationFactory")); }
{
setObjectName("CMakeRunConfigurationFactory");
registerRunConfiguration<CMakeRunConfiguration>();
}
// used to show the list of possible additons to a project, returns a list of ids
QList<Core::Id> CMakeRunConfigurationFactory::availableCreationIds(Target *parent, CreationMode mode) const
@@ -264,13 +267,6 @@ bool CMakeRunConfigurationFactory::canClone(Target *parent, RunConfiguration *so
return source->id().name().startsWith(CMAKE_RC_PREFIX);
}
RunConfiguration *CMakeRunConfigurationFactory::clone(Target *parent, RunConfiguration * source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<CMakeRunConfiguration>(parent, source);
}
bool CMakeRunConfigurationFactory::canRestore(Target *parent, const QVariantMap &map) const
{
if (!qobject_cast<CMakeProject *>(parent->project()))

2
src/plugins/cmakeprojectmanager/cmakerunconfiguration.h
View File

@@ -90,8 +90,6 @@ public:
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *product) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *product) override;
QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const override;
QString displayNameForId(Core::Id id) const override;

11
src/plugins/ios/iosrunfactories.cpp
View File

@@ -64,7 +64,8 @@ static Utils::FileName pathFromId(Core::Id id)
IosRunConfigurationFactory::IosRunConfigurationFactory(QObject *parent)
: QmakeRunConfigurationFactory(parent)
{
setObjectName(QLatin1String("IosRunConfigurationFactory"));
setObjectName("IosRunConfigurationFactory");
registerRunConfiguration<IosRunConfiguration>();
}
bool IosRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
@@ -103,14 +104,6 @@ QString IosRunConfigurationFactory::displayNameForId(Core::Id id) const
return pathFromId(id).toFileInfo().completeBaseName();
}
RunConfiguration *IosRunConfigurationFactory::clone(Target *parent, RunConfiguration *source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<IosRunConfiguration>(parent, source);
}
bool IosRunConfigurationFactory::canHandle(Target *t) const
{
if (!t->project()->supportsKit(t->kit()))

2
src/plugins/ios/iosrunfactories.h
View File

@@ -52,8 +52,6 @@ public:
bool canClone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) override;
bool canHandle(ProjectExplorer::Target *t) const override;
QList<ProjectExplorer::RunConfiguration *> runConfigurationsForNode(ProjectExplorer::Target *t,

13
src/plugins/nim/project/nimrunconfigurationfactory.cpp
View File

@@ -39,7 +39,9 @@ using namespace ProjectExplorer;
namespace Nim {
NimRunConfigurationFactory::NimRunConfigurationFactory()
{}
{
registerRunConfiguration<NimRunConfiguration>();
}
QList<Core::Id> NimRunConfigurationFactory::availableCreationIds(Target *parent,
IRunConfigurationFactory::CreationMode mode) const
@@ -76,15 +78,6 @@ bool NimRunConfigurationFactory::canClone(Target *parent, RunConfiguration *prod
return canHandle(parent);
}
RunConfiguration *NimRunConfigurationFactory::clone(Target *parent, RunConfiguration *product)
{
QTC_ASSERT(parent, return nullptr);
QTC_ASSERT(product, return nullptr);
std::unique_ptr<NimRunConfiguration> result(
createHelper<NimRunConfiguration>(parent, Constants::C_NIMRUNCONFIGURATION_ID));
return result->fromMap(product->toMap()) ? result.release() : nullptr;
}
bool NimRunConfigurationFactory::canHandle(Target *parent) const
{
Q_UNUSED(parent);

11
src/plugins/nim/project/nimrunconfigurationfactory.h
View File

@@ -39,15 +39,8 @@ public:
QString displayNameForId(Core::Id id) const override;
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent,
const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *product) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *product) override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *product) const override;
private:
bool canHandle(ProjectExplorer::Target *parent) const;

13
src/plugins/projectexplorer/customexecutablerunconfiguration.cpp
View File

@@ -314,7 +314,10 @@ Abi CustomExecutableRunConfiguration::abi() const
CustomExecutableRunConfigurationFactory::CustomExecutableRunConfigurationFactory(QObject *parent) :
IRunConfigurationFactory(parent)
{ setObjectName(QLatin1String("CustomExecutableRunConfigurationFactory")); }
{
setObjectName("CustomExecutableRunConfigurationFactory");
registerRunConfiguration<CustomExecutableRunConfiguration>();
}
bool CustomExecutableRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
{
@@ -352,14 +355,6 @@ bool CustomExecutableRunConfigurationFactory::canClone(Target *parent,
return canCreate(parent, source->id());
}
RunConfiguration *
CustomExecutableRunConfigurationFactory::clone(Target *parent, RunConfiguration *source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<CustomExecutableRunConfiguration>(parent, source);
}
bool CustomExecutableRunConfigurationFactory::canHandle(Target *parent) const
{
return parent->project()->supportsKit(parent->kit());

1
src/plugins/projectexplorer/customexecutablerunconfiguration.h
View File

@@ -101,7 +101,6 @@ public:
bool canCreate(Target *parent, Core::Id id) const override;
bool canRestore(Target *parent, const QVariantMap &map) const override;
bool canClone(Target *parent, RunConfiguration *product) const override;
RunConfiguration *clone(Target *parent, RunConfiguration *source) override;
private:
bool canHandle(Target *parent) const;

10
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -471,6 +471,16 @@ RunConfiguration *IRunConfigurationFactory::restore(Target *parent, const QVaria
return rc;
}
RunConfiguration *IRunConfigurationFactory::clone(Target *parent, RunConfiguration *product)
{
QTC_ASSERT(m_creator, return nullptr);
if (!canClone(parent, product))
return nullptr;
RunConfiguration *runConfig = m_creator(parent);
runConfig->copyFrom(product);
return runConfig;
}
IRunConfigurationFactory *IRunConfigurationFactory::find(Target *parent, const QVariantMap &map)
{
return ExtensionSystem::PluginManager::getObject<IRunConfigurationFactory>(

20
src/plugins/projectexplorer/runconfiguration.h
View File

@@ -293,7 +293,7 @@ public:
virtual bool canRestore(Target *parent, const QVariantMap &map) const = 0;
RunConfiguration *restore(Target *parent, const QVariantMap &map);
virtual bool canClone(Target *parent, RunConfiguration *product) const = 0;
virtual RunConfiguration *clone(Target *parent, RunConfiguration *product) = 0;
RunConfiguration *clone(Target *parent, RunConfiguration *product);
static IRunConfigurationFactory *find(Target *parent, const QVariantMap &map);
static IRunConfigurationFactory *find(Target *parent, RunConfiguration *rc);
@@ -306,19 +306,23 @@ public:
return runConfig;
}
template <class RunConfig>
static RunConfig *cloneHelper(Target *target, const RunConfiguration *source) {
auto runConfig = new RunConfig(target);
runConfig->copyFrom(source);
return runConfig;
}
signals:
void availableCreationIdsChanged();
protected:
using RunConfigurationCreator = std::function<RunConfiguration *(Target *)>;
template <class RunConfig>
void registerRunConfiguration()
{
m_creator = [](Target *t) -> RunConfiguration * { return new RunConfig(t); };
}
private:
virtual RunConfiguration *doCreate(Target *parent, Core::Id id) = 0;
virtual RunConfiguration *doRestore(Target *parent, const QVariantMap &map) = 0;
RunConfigurationCreator m_creator;
};
class PROJECTEXPLORER_EXPORT RunConfigWidget : public QWidget

8
src/plugins/pythoneditor/pythoneditorplugin.cpp
View File

@@ -278,6 +278,7 @@ public:
PythonRunConfigurationFactory()
{
setObjectName("PythonRunConfigurationFactory");
registerRunConfiguration<PythonRunConfiguration>();
}
QList<Core::Id> availableCreationIds(Target *parent, CreationMode mode) const override
@@ -323,13 +324,6 @@ public:
return source->id().name().startsWith(PythonRunConfigurationPrefix);
}
RunConfiguration *clone(Target *parent, RunConfiguration *source) override
{
if (!canClone(parent, source))
return 0;
return cloneHelper<PythonRunConfiguration>(parent, source);
}
private:
bool canHandle(Target *parent) const { return dynamic_cast<PythonProject *>(parent->project()); }

10
src/plugins/qbsprojectmanager/qbsrunconfiguration.cpp
View File

@@ -353,7 +353,8 @@ void QbsRunConfigurationWidget::setExecutableLineText(const QString &text)
QbsRunConfigurationFactory::QbsRunConfigurationFactory(QObject *parent) :
IRunConfigurationFactory(parent)
{
setObjectName(QLatin1String("QbsRunConfigurationFactory"));
setObjectName("QbsRunConfigurationFactory");
registerRunConfiguration<QbsRunConfiguration>();
}
bool QbsRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
@@ -387,13 +388,6 @@ bool QbsRunConfigurationFactory::canClone(Target *parent, RunConfiguration *sour
return canCreate(parent, source->id());
}
RunConfiguration *QbsRunConfigurationFactory::clone(Target *parent, RunConfiguration *source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<QbsRunConfiguration>(parent, source);
}
QList<Core::Id> QbsRunConfigurationFactory::availableCreationIds(Target *parent, CreationMode mode) const
{
QList<qbs::ProductData> products;

1
src/plugins/qbsprojectmanager/qbsrunconfiguration.h
View File

@@ -113,7 +113,6 @@ public:
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) override;
QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const override;
QString displayNameForId(Core::Id id) const override;

8
src/plugins/qmakeandroidsupport/qmakeandroidrunfactories.cpp
View File

@@ -49,6 +49,7 @@ static const char ANDROID_RC_ID_PREFIX[] = "Qt4ProjectManager.AndroidRunConfigur
QmakeAndroidRunConfigurationFactory::QmakeAndroidRunConfigurationFactory(QObject *parent)
: IRunConfigurationFactory(parent)
{
registerRunConfiguration<QmakeAndroidRunConfiguration>();
}
QString QmakeAndroidRunConfigurationFactory::displayNameForId(Core::Id id) const
@@ -97,13 +98,6 @@ RunConfiguration *QmakeAndroidRunConfigurationFactory::doRestore(Target *parent,
return createHelper<QmakeAndroidRunConfiguration>(parent, id);
}
RunConfiguration *QmakeAndroidRunConfigurationFactory::clone(Target *parent, RunConfiguration *source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<QmakeAndroidRunConfiguration>(parent, source);
}
bool QmakeAndroidRunConfigurationFactory::canHandle(Target *t) const
{
return t->project()->supportsKit(t->kit())

3
src/plugins/qmakeandroidsupport/qmakeandroidrunfactories.h
View File

@@ -47,11 +47,8 @@ public:
QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode = UserCreate) const override;
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) override;
QList<ProjectExplorer::RunConfiguration *> runConfigurationsForNode(ProjectExplorer::Target *t,
ProjectExplorer::Node *n);

10
src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.cpp
View File

@@ -439,7 +439,8 @@ QPair<QString, QString> DesktopQmakeRunConfiguration::extractWorkingDirAndExecut
DesktopQmakeRunConfigurationFactory::DesktopQmakeRunConfigurationFactory(QObject *parent) :
QmakeRunConfigurationFactory(parent)
{
setObjectName(QLatin1String("DesktopQmakeRunConfigurationFactory"));
setObjectName("DesktopQmakeRunConfigurationFactory");
registerRunConfiguration<DesktopQmakeRunConfiguration>();
}
bool DesktopQmakeRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
@@ -472,13 +473,6 @@ bool DesktopQmakeRunConfigurationFactory::canClone(Target *parent, RunConfigurat
return canCreate(parent, source->id());
}
RunConfiguration *DesktopQmakeRunConfigurationFactory::clone(Target *parent, RunConfiguration *source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<DesktopQmakeRunConfiguration>(parent, source);
}
QList<Core::Id> DesktopQmakeRunConfigurationFactory::availableCreationIds(Target *parent, CreationMode mode) const
{
if (!canHandle(parent))

2
src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.h
View File

@@ -143,8 +143,6 @@ public:
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) override;
QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const override;
QString displayNameForId(Core::Id id) const override;

11
src/plugins/qmlprojectmanager/qmlprojectrunconfigurationfactory.cpp
View File

@@ -39,7 +39,8 @@ namespace Internal {
QmlProjectRunConfigurationFactory::QmlProjectRunConfigurationFactory(QObject *parent) :
ProjectExplorer::IRunConfigurationFactory(parent)
{
setObjectName(QLatin1String("QmlProjectRunConfigurationFactory"));
setObjectName("QmlProjectRunConfigurationFactory");
registerRunConfiguration<QmlProjectRunConfiguration>();
}
QList<Core::Id> QmlProjectRunConfigurationFactory::availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const
@@ -123,14 +124,6 @@ bool QmlProjectRunConfigurationFactory::canClone(ProjectExplorer::Target *parent
return canCreate(parent, source->id());
}
ProjectExplorer::RunConfiguration *QmlProjectRunConfigurationFactory::clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<QmlProjectRunConfiguration>(parent, source);
}
bool QmlProjectRunConfigurationFactory::canHandle(ProjectExplorer::Target *parent) const
{
if (!parent->project()->supportsKit(parent->kit()))

1
src/plugins/qmlprojectmanager/qmlprojectrunconfigurationfactory.h
View File

@@ -43,7 +43,6 @@ public:
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) override;
private:
bool canHandle(ProjectExplorer::Target *parent) const;

9
src/plugins/qnx/qnxrunconfigurationfactory.cpp
View File

@@ -45,6 +45,7 @@ static Utils::FileName pathFromId(Core::Id id)
QnxRunConfigurationFactory::QnxRunConfigurationFactory(QObject *parent) :
ProjectExplorer::IRunConfigurationFactory(parent)
{
registerRunConfiguration<QnxRunConfiguration>();
}
QList<Core::Id> QnxRunConfigurationFactory::availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const
@@ -115,14 +116,6 @@ bool QnxRunConfigurationFactory::canClone(ProjectExplorer::Target *parent, Proje
return canCreate(parent, source->id());
}
ProjectExplorer::RunConfiguration *QnxRunConfigurationFactory::clone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source)
{
if (!canClone(parent, source))
return 0;
return cloneHelper<QnxRunConfiguration>(parent, source);
}
bool QnxRunConfigurationFactory::canHandle(ProjectExplorer::Target *t) const
{
Core::Id deviceType = ProjectExplorer::DeviceTypeKitInformation::deviceTypeId(t->kit());

4
src/plugins/qnx/qnxrunconfigurationfactory.h
View File

@@ -42,12 +42,8 @@ public:
QString displayNameForId(Core::Id id) const override;
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) override;
private:
bool canHandle(ProjectExplorer::Target *t) const;

19
src/plugins/remotelinux/remotelinuxrunconfigurationfactory.cpp
View File

@@ -63,7 +63,8 @@ static bool canHandle(const Target *target)
RemoteLinuxRunConfigurationFactory::RemoteLinuxRunConfigurationFactory(QObject *parent)
: IRunConfigurationFactory(parent)
{
setObjectName(QLatin1String("RemoteLinuxRunConfigurationFactory"));
setObjectName("RemoteLinuxRunConfigurationFactory");
registerRunConfiguration<RemoteLinuxRunConfiguration>();
}
bool RemoteLinuxRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
@@ -116,20 +117,13 @@ RunConfiguration *RemoteLinuxRunConfigurationFactory::doRestore(Target *parent,
return createHelper<RemoteLinuxRunConfiguration>(parent, RemoteLinuxRunConfiguration::IdPrefix, QString());
}
RunConfiguration *RemoteLinuxRunConfigurationFactory::clone(Target *parent,
RunConfiguration *source)
{
QTC_ASSERT(canClone(parent, source), return 0);
return cloneHelper<RemoteLinuxRunConfiguration>(parent, source);
}
// RemoteLinuxCustomRunConfigurationFactory
RemoteLinuxCustomRunConfigurationFactory::RemoteLinuxCustomRunConfigurationFactory(QObject *parent)
: IRunConfigurationFactory(parent)
{
setObjectName("RemoteLinuxCustomRunConfiguration");
registerRunConfiguration<RemoteLinuxCustomRunConfiguration>();
}
bool RemoteLinuxCustomRunConfigurationFactory::canCreate(Target *parent, Core::Id id) const
@@ -179,12 +173,5 @@ RunConfiguration *RemoteLinuxCustomRunConfigurationFactory::doRestore(Target *pa
return createHelper<RemoteLinuxCustomRunConfiguration>(parent);
}
RunConfiguration *RemoteLinuxCustomRunConfigurationFactory::clone(Target *parent,
RunConfiguration *source)
{
QTC_ASSERT(canClone(parent, source), return 0);
return cloneHelper<RemoteLinuxCustomRunConfiguration>(parent, source);
}
} // namespace Internal
} // namespace RemoteLinux

8
src/plugins/remotelinux/remotelinuxrunconfigurationfactory.h
View File

@@ -41,12 +41,8 @@ public:
QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const override;
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) override;
private:
ProjectExplorer::RunConfiguration *doCreate(ProjectExplorer::Target *parent, Core::Id id) override;
@@ -65,12 +61,8 @@ public:
QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const override;
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *source) override;
private:
ProjectExplorer::RunConfiguration *doCreate(ProjectExplorer::Target *parent, Core::Id id) override;

8
src/plugins/winrt/winrtrunfactories.cpp
View File

@@ -55,6 +55,7 @@ static bool isKitCompatible(Kit *kit)
WinRtRunConfigurationFactory::WinRtRunConfigurationFactory()
{
registerRunConfiguration<WinRtRunConfiguration>();
}
QList<Core::Id> WinRtRunConfigurationFactory::availableCreationIds(Target *parent,
@@ -104,13 +105,6 @@ bool WinRtRunConfigurationFactory::canClone(Target *parent, RunConfiguration *pr
return false;
}
RunConfiguration *WinRtRunConfigurationFactory::clone(Target *parent, RunConfiguration *product)
{
Q_UNUSED(parent);
Q_UNUSED(product);
return 0;
}
bool WinRtRunConfigurationFactory::canHandle(Target *parent) const
{
if (!isKitCompatible(parent->kit()))

2
src/plugins/winrt/winrtrunfactories.h
View File

@@ -43,8 +43,6 @@ public:
bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override;
bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override;
bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *product) const override;
ProjectExplorer::RunConfiguration *clone(ProjectExplorer::Target *parent,
ProjectExplorer::RunConfiguration *product) override;
private:
bool canHandle(ProjectExplorer::Target *parent) const;