feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CompilerExplorer: Fix assert

Browse Source 
The default value was not correctly converted to a QVariant.
When a LibraryAspect was de-serialized from the default variant value,
it would create q QVariant<QMap<QString, QString>> which cannot be converted
to a Store by Utils::storeFromVariant and would end in an assert therefore.

Change-Id: I6f7b14d78793a07f027a6b375bc554941ffb83de
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-12-12 14:06:47 +01:00
parent a047ebba50
commit e037bb0621
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/compilerexplorer/compilerexploreraspects.cpp
View File

@@ -78,6 +78,11 @@ QVariant LibrarySelectionAspect::volatileVariantValue() const
return toVariantMap(m_buffer); return toVariantMap(m_buffer);
} }
QVariant LibrarySelectionAspect::defaultVariantValue() const
{
return toVariantMap(defaultValue());
}
void LibrarySelectionAspect::setVariantValue(const QVariant &value, Announcement howToAnnounce) void LibrarySelectionAspect::setVariantValue(const QVariant &value, Announcement howToAnnounce)
{ {
QMap<QString, QString> map; QMap<QString, QString> map;

1
src/plugins/compilerexplorer/compilerexploreraspects.h
View File

@@ -80,6 +80,7 @@ public:
QVariant variantValue() const override; QVariant variantValue() const override;
QVariant volatileVariantValue() const override; QVariant volatileVariantValue() const override;
QVariant defaultVariantValue() const override;
void setVariantValue(const QVariant &value, Announcement howToAnnounce = DoEmit) override; void setVariantValue(const QVariant &value, Announcement howToAnnounce = DoEmit) override;