feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Move currentState to AbstractView

Browse Source 
Change-Id: I3252d85dceff606c85898895e91b7e955441033b
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
This commit is contained in:
Marco Bubke
2013-07-31 15:22:28 +02:00
parent 0dd5f68152
commit e06f7e1db7
9 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/components/componentcore/selectioncontext.cpp
View File

@@ -63,7 +63,7 @@ bool SelectionContext::singleNodeIsSelected() const
bool SelectionContext::isInBaseState() const
{
return QmlModelState(view()->currentStateNode()).isBaseState();
return view()->currentState().isBaseState();
}
ModelNode SelectionContext::currentSingleSelectedNode() const

3
src/plugins/qmldesigner/components/formeditor/movetool.cpp
View File

@@ -95,8 +95,7 @@ void MoveTool::mouseMoveEvent(const QList<QGraphicsItem*> &itemList,
m_resizeIndicator.hide();
FormEditorItem *containerItem = containerFormEditorItem(itemList, m_movingItems);
if (containerItem
&& QmlModelState::isBaseState(view()->currentStateNode())) {
if (containerItem && view()->currentState().isBaseState()) {
if (containerItem != m_movingItems.first()->parentItem()
&& event->modifiers().testFlag(Qt::ShiftModifier)) {
m_moveManipulator.reparentTo(containerItem);

2
src/plugins/qmldesigner/components/propertyeditor/propertyeditor.cpp
View File

@@ -738,7 +738,7 @@ void PropertyEditor::resetView()
NodeType *type = m_typeHash.value(qmlFile.toString());
QString currentStateName = QmlModelState::isValidQmlModelState(currentStateNode()) ? QmlModelState(currentStateNode()).name() : QLatin1String("invalid state");
QString currentStateName = currentState().isBaseState() ? currentState().name() : QLatin1String("invalid state");
if (!type) {
type = new NodeType(this);

5
src/plugins/qmldesigner/components/stateseditor/stateseditorview.cpp
View File

@@ -245,11 +245,6 @@ void StatesEditorView::duplicateCurrentState()
setCurrentState(newState);
}
QmlModelState StatesEditorView::currentState() const
{
return QmlModelState(currentStateNode());
}
void StatesEditorView::setCurrentState(const QmlModelState &state)
{
if (!model() && !state.isValid())

1
src/plugins/qmldesigner/components/stateseditor/stateseditorview.h
View File

@@ -49,7 +49,6 @@ public:
void renameState(int nodeId,const QString &newName);
bool validStateName(const QString &name) const;
QString currentStateName() const;
QmlModelState currentState() const;
void setCurrentState(const QmlModelState &state);
QmlModelState baseState() const;
QmlModelStateGroup rootStateGroup() const;

2
src/plugins/qmldesigner/designercore/include/abstractview.h
View File

@@ -57,6 +57,7 @@ namespace QmlDesigner {
class NodeInstanceView;
class RewriterView;
class QmlModelState;
class WidgetInfo {
@@ -235,6 +236,7 @@ public:
void setCurrentStateNode(const ModelNode &node);
ModelNode currentStateNode() const;
QmlModelState currentState() const;
int majorQtQuickVersion() const;

6
src/plugins/qmldesigner/designercore/model/abstractview.cpp
View File

@@ -33,6 +33,7 @@
#include "model_p.h"
#include "internalnode_p.h"
#include "nodeinstanceview.h"
#include <qmlstate.h>
namespace QmlDesigner {
@@ -537,6 +538,11 @@ ModelNode AbstractView::currentStateNode() const
return ModelNode();
}
QmlModelState AbstractView::currentState() const
{
return QmlModelState(currentStateNode());
}
static int getMajorVersionFromImport(const Model *model)
{
foreach (const Import &import, model->imports()) {

4
src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp
View File

@@ -155,7 +155,7 @@ QmlItemNode QmlItemNode::createQmlItemNode(AbstractView *view, const ItemLibrary
newQmlItemNode.setId(view->generateNewId("image"));
if (!QmlModelState(view->currentStateNode()).isBaseState()) {
if (!view->currentState().isBaseState()) {
newQmlItemNode.modelNode().variantProperty("opacity").setValue(0);
newQmlItemNode.setVariantProperty("opacity", 1);
}
@@ -221,7 +221,7 @@ QmlItemNode QmlItemNode::createQmlItemNodeFromImage(AbstractView *view, const QS
newQmlItemNode.setId(view->generateNewId("image"));
if (!QmlModelState(view->currentStateNode()).isBaseState()) {
if (!view->currentState().isBaseState()) {
newQmlItemNode.modelNode().variantProperty("opacity").setValue(0);
newQmlItemNode.setVariantProperty("opacity", 1);
}

2
src/plugins/qmldesigner/designercore/model/viewmanager.cpp
View File

@@ -67,7 +67,7 @@ void ViewManager::detachRewriterView()
void ViewManager::switchStateEditorViewToBaseState()
{
if (m_statesEditorView.isAttached()) {
m_savedState = QmlModelState(m_statesEditorView.currentStateNode());
m_savedState = m_statesEditorView.currentState();
m_statesEditorView.setCurrentState(m_statesEditorView.baseState());
}
}