feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PluginSpec: Use member initialization

Browse Source 
Change-Id: Ie8720248eca88ec447461b54b27928c25dace97e
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Eike Ziller
2017-01-03 15:28:42 +01:00
parent 5017d11958
commit e0dd885338
2 changed files with 11 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/libs/extensionsystem/pluginspec.cpp
View File

@@ -507,17 +507,7 @@ namespace {
\internal \internal
*/ */
PluginSpecPrivate::PluginSpecPrivate(PluginSpec *spec) PluginSpecPrivate::PluginSpecPrivate(PluginSpec *spec)
: required(false), : q(spec)
experimental(false),
enabledByDefault(true),
enabledBySettings(true),
enabledIndirectly(false),
forceEnabled(false),
forceDisabled(false),
plugin(0),
state(PluginSpec::Invalid),
hasError(false),
q(spec)
{ {
} }

20
src/libs/extensionsystem/pluginspec_p.h
View File

@@ -70,9 +70,9 @@ public:
QString name; QString name;
QString version; QString version;
QString compatVersion; QString compatVersion;
bool required; bool required = false;
bool experimental; bool experimental = false;
bool enabledByDefault; bool enabledByDefault = true;
QString vendor; QString vendor;
QString copyright; QString copyright;
QString license; QString license;
@@ -81,10 +81,10 @@ public:
QString category; QString category;
QRegExp platformSpecification; QRegExp platformSpecification;
QVector<PluginDependency> dependencies; QVector<PluginDependency> dependencies;
bool enabledBySettings; bool enabledBySettings = true;
bool enabledIndirectly; bool enabledIndirectly = false;
bool forceEnabled; bool forceEnabled = false;
bool forceDisabled; bool forceDisabled = false;
QString location; QString location;
QString filePath; QString filePath;
@@ -92,10 +92,10 @@ public:
QHash<PluginDependency, PluginSpec *> dependencySpecs; QHash<PluginDependency, PluginSpec *> dependencySpecs;
PluginSpec::PluginArgumentDescriptions argumentDescriptions; PluginSpec::PluginArgumentDescriptions argumentDescriptions;
IPlugin *plugin; IPlugin *plugin = nullptr;
PluginSpec::State state; PluginSpec::State state = PluginSpec::Invalid;
bool hasError; bool hasError = false;
QString errorString; QString errorString;
static bool isValidVersion(const QString &version); static bool isValidVersion(const QString &version);