feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Fix transport of negative signed chars

Browse Source 
Change-Id: I9b25d4b8e4b68d9cef674581d1a42eb75e21ec56
Task-number: QTCREATORBUG-16353
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
Reviewed-by: hjk <hjk@theqtcompany.com>
This commit is contained in:
hjk
2016-05-27 13:19:16 +02:00
parent 752c2cd67f
commit e108d6fe48
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
share/qtcreator/debugger/gdbbridge.py
View File

@@ -1025,7 +1025,7 @@ class Dumper(DumperBase):
self.putType(typeName) self.putType(typeName)
if typeobj.sizeof == 1: if typeobj.sizeof == 1:
# Force unadorned value transport for char and Co. # Force unadorned value transport for char and Co.
self.putValue(int(value) & 0xff) self.putValue(int(value))
else: else:
self.putValue(value) self.putValue(value)
self.putNumChild(0) self.putNumChild(0)

18
tests/auto/debugger/tst_dumpers.cpp
View File

@@ -4758,6 +4758,24 @@ void tst_Dumpers::dumper_data()
+ Check("a.#1.i", "42", "int") % LldbEngine + Check("a.#1.i", "42", "int") % LldbEngine
+ Check("a.#2.f", ff, "float") % LldbEngine; + Check("a.#2.f", ff, "float") % LldbEngine;
QTest::newRow("Chars")
<< Data("#include <qglobal.h>\n",
"char c = -12;\n"
"signed char sc = -12;\n"
"unsigned char uc = -12;\n"
"qint8 qs = -12;\n"
"quint8 qu = -12;\n"
"unused(&c, &sc, &uc, &qs, &qu);\n")
+ Check("c", "-12", "char") // on all our platforms char is signed.
+ Check("sc", "-12", "signed char") % NoCdbEngine
+ Check("sc", "-12", "char") % CdbEngine
+ Check("uc", "244", "unsigned char")
+ Check("qs", "-12", "@qint8") % NoCdbEngine
+ Check("qs", "-12", "char") % CdbEngine
+ Check("qu", "244", "@quint8") % NoCdbEngine
+ Check("qu", "244", "unsigned char") % CdbEngine;
QTest::newRow("CharArrays") QTest::newRow("CharArrays")
<< Data("char s[] = \"aöa\";\n" << Data("char s[] = \"aöa\";\n"