feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

HighlightScrollbar: Avoid creation of unneeded temporary container

Browse Source 
Change-Id: I764f8f376b4a626d5258abb2fdd4ec7484b2c8c9
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Eike Ziller
2017-10-19 10:38:34 +02:00
parent 867d401b82
commit e174969c15
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/coreplugin/find/highlightscrollbar.cpp
View File

@@ -293,10 +293,11 @@ void HighlightScrollBarOverlay::paintEvent(QPaintEvent *paintEvent)
QPainter painter(this); QPainter painter(this);
painter.setRenderHint(QPainter::Antialiasing, false); painter.setRenderHint(QPainter::Antialiasing, false);
foreach (Utils::Theme::Color themeColor, highlights.keys()) { const auto highlightEnd = highlights.cend();
const QColor &color = creatorTheme()->color(themeColor); for (auto highlightIt = highlights.cbegin(); highlightIt != highlightEnd; ++highlightIt) {
for (int i = 0, total = highlights[themeColor].size(); i < total; ++i) { const QColor &color = creatorTheme()->color(highlightIt.key());
const QRect rect = highlights[themeColor][i]; for (int i = 0, total = highlightIt.value().size(); i < total; ++i) {
const QRect rect = highlightIt.value().at(i);
painter.fillRect(rect, color); painter.fillRect(rect, color);
} }
} }