feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CrashHandler: Add "Attach and Debug" button.

Browse Source 
This will launch a new instance of Qt Creator attaching to the crashed
instance.

The 'Restart' functionality is now represented as a check box since it
would be confusing to have one button that restarts the app and quits
the crash handler and another one that starts a debugger but keeps the
crash handler open (which is necessary, otherwise the crashed app will
quit).

Change-Id: Id88f418ff73ab7bc72b05753ce2b61bbef8f30cf
Reviewed-by: Christian Kandeler <christian.kandeler@digia.com>
This commit is contained in:
Nikolai Kosjar
2012-09-24 16:05:43 +02:00
parent 0f27043fe6
commit e186f9b257
9 changed files with 240 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
src/tools/qtcreatorcrashhandler/crashhandlerdialog.cpp
View File

@@ -34,9 +34,15 @@
#include "utils.h"
#include <app/app_version.h>
#include <utils/checkablemessagebox.h>
#include <QClipboard>
#include <QIcon>
#include <QSettings>
static const char SettingsApplication[] = "QtCreator";
static const char SettingsKeySkipWarningAbortingBacktrace[]
= "CrashHandler/SkipWarningAbortingBacktrace";
CrashHandlerDialog::CrashHandlerDialog(CrashHandler *handler, QWidget *parent) :
QDialog(parent),
@@ -59,8 +65,8 @@ CrashHandlerDialog::CrashHandlerDialog(CrashHandler *handler, QWidget *parent) :
connect(m_ui->copyToClipBoardButton, SIGNAL(clicked()), this, SLOT(copyToClipboardClicked()));
connect(m_ui->reportBugButton, SIGNAL(clicked()), m_crashHandler, SLOT(openBugTracker()));
connect(m_ui->restartAppButton, SIGNAL(clicked()), m_crashHandler, SLOT(restartApplication()));
connect(m_ui->closeButton, SIGNAL(clicked()), qApp, SLOT(quit()));
connect(m_ui->debugAppButton, SIGNAL(clicked()), m_crashHandler, SLOT(debugApplication()));
connect(m_ui->closeButton, SIGNAL(clicked()), this, SLOT(close()));
setApplicationInfo();
}
@@ -70,6 +76,34 @@ CrashHandlerDialog::~CrashHandlerDialog()
delete m_ui;
}
bool CrashHandlerDialog::runDebuggerWhileBacktraceNotFinished()
{
// Check settings.
QSettings settings(QSettings::IniFormat, QSettings::UserScope,
QLatin1String(Core::Constants::IDE_SETTINGSVARIANT_STR),
QLatin1String(SettingsApplication));
if (settings.value(QLatin1String(SettingsKeySkipWarningAbortingBacktrace), false).toBool())
return true;
// Ask user.
const QString title = tr("Run Debugger And Abort Collecting Backtrace?");
const QString message = tr(
"<html><head/><body>"
"<p><b>Run the debugger and abort collecting backtrace?</b></p>"
"<p>You have requested to run the debugger while collecting the backtrace was not "
"finished.</p>"
"</body></html>");
const QString checkBoxText = tr("Do not &ask again.");
bool checkBoxSetting = false;
const QDialogButtonBox::StandardButton button = Utils::CheckableMessageBox::question(this,
title, message, checkBoxText, &checkBoxSetting,
QDialogButtonBox::Yes|QDialogButtonBox::No, QDialogButtonBox::No);
if (checkBoxSetting)
settings.setValue(QLatin1String(SettingsKeySkipWarningAbortingBacktrace), checkBoxSetting);
return button == QDialogButtonBox::Yes;
}
void CrashHandlerDialog::setToFinalState()
{
m_ui->progressBar->hide();
@@ -77,9 +111,14 @@ void CrashHandlerDialog::setToFinalState()
m_ui->reportBugButton->setEnabled(true);
}
void CrashHandlerDialog::disableRestartAppButton()
void CrashHandlerDialog::disableRestartAppCheckBox()
{
m_ui->restartAppButton->setDisabled(true);
m_ui->restartAppCheckBox->setDisabled(true);
}
void CrashHandlerDialog::disableDebugAppButton()
{
m_ui->debugAppButton->setDisabled(true);
}
void CrashHandlerDialog::setApplicationInfo()
@@ -130,3 +169,10 @@ void CrashHandlerDialog::copyToClipboardClicked()
{
QApplication::clipboard()->setText(m_ui->debugInfoEdit->toPlainText());
}
void CrashHandlerDialog::close()
{
if (m_ui->restartAppCheckBox->isEnabled() && m_ui->restartAppCheckBox->isChecked())
m_crashHandler->restartApplication();
qApp->quit();
}