From e1e11ae15df23974c4925858cbb80be403eb0824 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Thu, 7 Jun 2018 14:54:57 +0200 Subject: [PATCH] Clang: Fix testCompleteFunctions() With recent clang versions we can show default arguments properly. Change-Id: I6028db183b0413650a32928d0051afb9402c5e32 Reviewed-by: Ivan Donchevskii --- src/plugins/clangcodemodel/test/clangcodecompletion_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/clangcodemodel/test/clangcodecompletion_test.cpp b/src/plugins/clangcodemodel/test/clangcodecompletion_test.cpp index 423f2395c23..7aada9a48cd 100644 --- a/src/plugins/clangcodemodel/test/clangcodecompletion_test.cpp +++ b/src/plugins/clangcodemodel/test/clangcodecompletion_test.cpp @@ -555,8 +555,8 @@ void ClangCodeCompletionTest::testCompleteFunctions() QVERIFY(hasItem(t.proposal, "void f()")); QVERIFY(hasItem(t.proposal, "void f(int a)")); QVERIFY(hasItem(t.proposal, "void f(const QString &s)")); - QVERIFY(hasItem(t.proposal, "void f(char c, int optional)")); // TODO: No default argument? - QVERIFY(hasItem(t.proposal, "void f(char c, int optional1, int optional2)")); // TODO: No default argument? + QVERIFY(hasItem(t.proposal, "void f(char c, int optional = 3)")); + QVERIFY(hasItem(t.proposal, "void f(char c, int optional1 = 3, int optional2 = 3)")); QVERIFY(hasItem(t.proposal, "void f(const TType<QString> *t)")); QVERIFY(hasItem(t.proposal, "TType<QString> f(bool)")); }