From e20358195679d86516230c10d01f9ed47d4c4001 Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Thu, 2 Sep 2021 13:57:42 +0200 Subject: [PATCH] Core: Remove 'dllimport' attribute warning By having the function body in the class we automatically get the same inline functionality and get rid of the warnings below on LLVM Clang 13. src/plugins\coreplugin/find/ifindsupport.h:71:27: warning: 'Core::IFindSupport::highlightAll' redeclared inline; 'dllimport' attribute ignored [-Wignored-attributes] Change-Id: I0daa6412678090f45bdfb6401157cb68bcb0241f Reviewed-by: Eike Ziller --- src/plugins/coreplugin/find/ifindsupport.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plugins/coreplugin/find/ifindsupport.h b/src/plugins/coreplugin/find/ifindsupport.h index 213e1feb0d9..5939bdd07db 100644 --- a/src/plugins/coreplugin/find/ifindsupport.h +++ b/src/plugins/coreplugin/find/ifindsupport.h @@ -49,7 +49,7 @@ public: virtual QString currentFindString() const = 0; virtual QString completedFindString() const = 0; - virtual void highlightAll(const QString &txt, FindFlags findFlags); + virtual void highlightAll(const QString &txt, FindFlags findFlags) {} virtual Result findIncremental(const QString &txt, FindFlags findFlags) = 0; virtual Result findStep(const QString &txt, FindFlags findFlags) = 0; virtual void replace(const QString &before, const QString &after, @@ -68,6 +68,4 @@ signals: void changed(); }; -inline void IFindSupport::highlightAll(const QString &, FindFlags) {} - } // namespace Core