diff --git a/src/plugins/coreplugin/actionmanager/commandsfile.cpp b/src/plugins/coreplugin/actionmanager/commandsfile.cpp index a13229d464f..665ff16074e 100644 --- a/src/plugins/coreplugin/actionmanager/commandsfile.cpp +++ b/src/plugins/coreplugin/actionmanager/commandsfile.cpp @@ -101,7 +101,7 @@ QMap> CommandsFile::importCommands() const while (!r.atEnd()) { switch (r.readNext()) { case QXmlStreamReader::StartElement: { - const QStringRef name = r.name(); + const auto name = r.name(); if (name == ctx.shortCutElement) { currentId = r.attributes().value(ctx.idAttribute).toString(); if (!result.contains(currentId)) diff --git a/src/plugins/coreplugin/documentmanager.cpp b/src/plugins/coreplugin/documentmanager.cpp index d66ff8453cb..e967e999c7f 100644 --- a/src/plugins/coreplugin/documentmanager.cpp +++ b/src/plugins/coreplugin/documentmanager.cpp @@ -825,14 +825,14 @@ QString DocumentManager::getSaveFileName(const QString &title, const QString &pa const QRegularExpressionMatch match = matchIt.next(); QString caption = match.captured(1); caption.remove(QLatin1Char('*')); - const QVector suffixes = caption.splitRef(QLatin1Char(' ')); - for (const QStringRef &suffix : suffixes) + const QStringList suffixes = caption.split(QLatin1Char(' ')); + for (const QString &suffix : suffixes) if (fileName.endsWith(suffix)) { suffixOk = true; break; } if (!suffixOk && !suffixes.isEmpty()) - fileName.append(suffixes.at(0).toString()); + fileName.append(suffixes.at(0)); } } if (QFile::exists(fileName)) { diff --git a/src/plugins/coreplugin/externaltool.cpp b/src/plugins/coreplugin/externaltool.cpp index ae8dae407c8..8994686cace 100644 --- a/src/plugins/coreplugin/externaltool.cpp +++ b/src/plugins/coreplugin/externaltool.cpp @@ -351,7 +351,7 @@ static void localizedText(const QStringList &locales, QXmlStreamReader *reader, static bool parseOutputAttribute(const QString &attribute, QXmlStreamReader *reader, ExternalTool::OutputHandling *value) { - const QStringRef output = reader->attributes().value(attribute); + const auto output = reader->attributes().value(attribute); if (output == kOutputShowInPane) { *value = ExternalTool::ShowInPane; } else if (output == kOutputReplaceSelection) { @@ -405,7 +405,7 @@ ExternalTool * ExternalTool::createFromXml(const QByteArray &xml, QString *error break; } if (reader.attributes().hasAttribute(kModifiesDocument)) { - const QStringRef value = reader.attributes().value(kModifiesDocument); + const auto value = reader.attributes().value(kModifiesDocument); if (value == kYes || value == kTrue) { tool->m_modifiesCurrentDocument = true; } else if (value == kNo || value == kFalse) {