From e23121b142a6cd7cb2c91c96e72139d5b335a075 Mon Sep 17 00:00:00 2001 From: Henning Gruendl Date: Mon, 3 Jun 2024 17:04:38 +0200 Subject: [PATCH] QmlDesigner: Fix color property expression binding Fix setting an expression on a color property via the binding editor by using the actual expression instead of a quote stripped version of it. Task-number: QDS-12919 Change-Id: I877b9f622158a5a88b4fe6add968ded4e691cb20 Reviewed-by: Thomas Hartmann (cherry picked from commit 79e6c6809b820b6b4f55f4e6d1d1bc085ba13cb5) --- .../components/propertyeditor/propertyeditorview.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmldesigner/components/propertyeditor/propertyeditorview.cpp b/src/plugins/qmldesigner/components/propertyeditor/propertyeditorview.cpp index b22b39e238b..441c2d29aaf 100644 --- a/src/plugins/qmldesigner/components/propertyeditor/propertyeditorview.cpp +++ b/src/plugins/qmldesigner/components/propertyeditor/propertyeditorview.cpp @@ -368,9 +368,9 @@ void PropertyEditorView::setExpressionOnObjectNode(const QmlObjectNode &constObj } } - if (qmlObjectNode.expression(name) != expression + if (qmlObjectNode.expression(name) != newExpression || !qmlObjectNode.propertyAffectedByCurrentState(name)) - qmlObjectNode.setBindingProperty(name, expression); + qmlObjectNode.setBindingProperty(name, newExpression); } void PropertyEditorView::generateAliasForProperty(const ModelNode &modelNode, const QString &name)